Replace didDispatch checks with explicit dispatch state

Author: autumn-mck

Framework/Core/include/Framework/MessageContext.h

@@ -502,7 +502,6 @@ class MessageContext
   o2::header::Stack* findMessageHeaderStack(const Output& spec);
   [[nodiscard]] int countDeviceOutputs(bool excludeDPLOrigin = false) const;
   void fakeDispatch() { mDispatchState = DispatchState::Dispatched; }
-  [[nodiscard]] bool didDispatch() const { return mDispatchState == DispatchState::Dispatched; }
   [[nodiscard]] DispatchState dispatchState() const { return mDispatchState; }
   o2::framework::DataProcessingHeader* findMessageDataProcessingHeader(const Output& spec);
   std::pair<o2::header::DataHeader*, o2::framework::DataProcessingHeader*> findMessageHeaders(const Output& spec);

Framework/Core/src/CommonServices.cxx

@@ -185,14 +185,15 @@ o2::framework::ServiceSpec CommonServices::streamContextSpec()
       auto& routes = processingContext.services().get<DeviceSpec const>().outputs;
       auto& timeslice = processingContext.services().get<TimingInfo>().timeslice;
       auto& messageContext = processingContext.services().get<MessageContext>();
+      auto dispatchState = messageContext.dispatchState();
       O2_SIGNPOST_ID_FROM_POINTER(cid, stream_context, service);
       // Do not report discarded messages as missing outputs.
-      if (messageContext.dispatchState() == MessageContext::DispatchState::Discarded) {
+      if (dispatchState == MessageContext::DispatchState::Discarded) {
         O2_SIGNPOST_EVENT_EMIT_ERROR(stream_context, cid, "postProcessingCallbacks", "Output messages discarded.");
         return;
       }
       // Check if we never created any data for this timeslice
-      // if we did not, but we still have didDispatched set to true
+      // if we did not, but messages were dispatched,
       // it means it was created out of band.
       bool userDidCreate = false;
       for (size_t ri = 0; ri < routes.size(); ++ri) {
@@ -203,14 +204,14 @@ o2::framework::ServiceSpec CommonServices::streamContextSpec()
       }
       O2_SIGNPOST_EVENT_EMIT(stream_context, cid, "postProcessingCallbacks", "userDidCreate == %d && didDispatch == %d",
                              userDidCreate,
-                             messageContext.didDispatch());
-      if (userDidCreate == false && messageContext.didDispatch() == true) {
+                             dispatchState == MessageContext::DispatchState::Dispatched);
+      if (userDidCreate == false && dispatchState == MessageContext::DispatchState::Dispatched) {
         O2_SIGNPOST_EVENT_EMIT(stream_context, cid, "postProcessingCallbacks", "Data created out of band userDidCreate == %d && messageContext.didDispatch == %d",
                                userDidCreate,
-                               messageContext.didDispatch());
+                               dispatchState == MessageContext::DispatchState::Dispatched);
         return;
       }
-      if (userDidCreate == false && messageContext.didDispatch() == false) {
+      if (userDidCreate == false && dispatchState == MessageContext::DispatchState::NotDispatched) {
         O2_SIGNPOST_ID_FROM_POINTER(cid, stream_context, service);
         O2_SIGNPOST_EVENT_EMIT(stream_context, cid, "postProcessingCallbacks", "No data created.");
         return;