fix(sdk-core): fix lint errors and await DKG restoreSession in tests

Fix prettier formatting in createOfflineKeyGenRound2Share (multi-line
decrypt call) and in test helper (function signature and initDkg args).
Remove unused variables from buildCounterPartyAndBitgoMsgs test helper.

Update sdk-lib-mpc DKG session management test to await restoreSession,
which is now async after the fix to load WASM before restoring state.

Ticket: WCI-890
Session-Id: 2b6d8843-9bec-4a05-8725-18d450b7f097
Task-Id: dcea3d67-b592-483a-967b-968cc01f5b76

Author: Support Bot

modules/sdk-core/src/bitgo/utils/tss/eddsa/eddsaMPCv2.ts

@@ -735,7 +735,10 @@ export class EddsaMPCv2Utils extends BaseEddsaUtils {
     const bitgoKeyObj = await pgp.readKey({ armoredKey: bitgoGpgPubKey });
     const counterPartyKeyObj = await pgp.readKey({ armoredKey: counterPartyGpgPubKey });
 
-    const decryptedRound1Session = await this.bitgo.decrypt({ input: encryptedRound1Session, password: walletPassphrase });
+    const decryptedRound1Session = await this.bitgo.decrypt({
+      input: encryptedRound1Session,
+      password: walletPassphrase,
+    });
 
     const { dkgSession, ownMsgPayload, ownMsgFrom } = JSON.parse(decryptedRound1Session) as {
       dkgSession: string;

modules/sdk-core/test/unit/bitgo/utils/tss/eddsa/eddsaMPCv2.ts

@@ -818,9 +818,7 @@ describe('EddsaMPCv2Utils.createOfflineKeyGenRound2Share', () => {
     eddsaMPCv2Utils = new EddsaMPCv2Utils(mockBitgo, mockCoin);
   });
 
-  async function runRound1(
-    partyId: MPCv2PartiesEnum.USER | MPCv2PartiesEnum.BACKUP = MPCv2PartiesEnum.USER
-  ): Promise<{
+  async function runRound1(partyId: MPCv2PartiesEnum.USER | MPCv2PartiesEnum.BACKUP = MPCv2PartiesEnum.USER): Promise<{
     result: { signedMsg1: MPSTypes.MPSSignedMessage; encryptedRound1Session: string };
     ownGpgKeyPair: pgp.SerializedKeyPair<string>;
     counterPartyGpgKeyPair: pgp.SerializedKeyPair<string>;
@@ -839,32 +837,19 @@ describe('EddsaMPCv2Utils.createOfflineKeyGenRound2Share', () => {
   }
 
   async function buildCounterPartyAndBitgoMsgs(
-    userRound1Result: MPSTypes.MPSSignedMessage,
+    _userRound1Result: MPSTypes.MPSSignedMessage,
     backupRound1Result: MPSTypes.MPSSignedMessage
   ): Promise<{ bitgoMsg1: MPSTypes.MPSSignedMessage; counterPartyMsg1ForUser: MPSTypes.MPSSignedMessage }> {
     const bitgoGpgPrivKey = await pgp.readPrivateKey({ armoredKey: bitgoGpgKeyPair.privateKey });
 
-    // Build a real user DKG round1 to get the bitgo msg
-    const userGpgPrivKey = await pgp.readPrivateKey({ armoredKey: userGpgKeyPair.privateKey });
-    const [, ownUserSk] = await MPSComms.extractEd25519KeyPair(userGpgPrivKey);
-
-    const backupGpgPrivKey = await pgp.readPrivateKey({ armoredKey: backupGpgKeyPair.privateKey });
-    const [, ownBackupSk] = await MPSComms.extractEd25519KeyPair(backupGpgPrivKey);
-
-    const bitgoGpgPubKeyObj = await pgp.readKey({ armoredKey: bitgoGpgKeyPair.publicKey });
-    const bitgoPk = await MPSComms.extractEd25519PublicKey(bitgoGpgPubKeyObj);
-
     const userGpgPubKeyObj = await pgp.readKey({ armoredKey: userGpgKeyPair.publicKey });
     const userPk = await MPSComms.extractEd25519PublicKey(userGpgPubKeyObj);
 
     const backupGpgPubKeyObj = await pgp.readKey({ armoredKey: backupGpgKeyPair.publicKey });
     const backupPk = await MPSComms.extractEd25519PublicKey(backupGpgPubKeyObj);
 
     const bitgoDkg = new EddsaMPSDkg.DKG(3, 2, MPCv2PartiesEnum.BITGO);
-    await bitgoDkg.initDkg(
-      (await MPSComms.extractEd25519KeyPair(bitgoGpgPrivKey))[1],
-      [userPk, backupPk]
-    );
+    await bitgoDkg.initDkg((await MPSComms.extractEd25519KeyPair(bitgoGpgPrivKey))[1], [userPk, backupPk]);
     const bitgoRawMsg1 = bitgoDkg.getFirstMessage();
     const bitgoMsg1 = await MPSComms.detachSignMpsMessage(Buffer.from(bitgoRawMsg1.payload), bitgoGpgPrivKey);
 

modules/sdk-lib-mpc/test/unit/tss/eddsa/dkg.ts

@@ -286,9 +286,9 @@ describe('EdDSA MPS DKG', function () {
       const restoredBackup = new EddsaMPSDkg.DKG(3, 2, 1);
       const restoredBitgo = new EddsaMPSDkg.DKG(3, 2, 2);
 
-      restoredUser.restoreSession(userSession);
-      restoredBackup.restoreSession(backupSession);
-      restoredBitgo.restoreSession(bitgoSession);
+      await restoredUser.restoreSession(userSession);
+      await restoredBackup.restoreSession(backupSession);
+      await restoredBitgo.restoreSession(bitgoSession);
 
       assert.strictEqual(restoredUser.getState(), user.getState(), 'Restored state should match original');
       assert.strictEqual(restoredBackup.getState(), backup.getState(), 'Restored backup state should match original');