From 172154ea6da582b0fcb18adf9b7e6eafe194f349 Mon Sep 17 00:00:00 2001 From: seonghobae <8172694+seonghobae@users.noreply.github.com> Date: Sun, 9 Aug 2026 10:50:50 +0000 Subject: [PATCH 1/9] =?UTF-8?q?=F0=9F=A7=B9=20[=EC=BD=94=EB=93=9C=20?= =?UTF-8?q?=ED=97=AC=EC=8A=A4=20=EA=B0=9C=EC=84=A0]=20validate=5Fcandidate?= =?UTF-8?q?=20=ED=95=A8=EC=88=98=20=EB=A6=AC=ED=8C=A9=ED=86=A0=EB=A7=81?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../ci/assert_opencode_reasoning_effort.py | 38 +++++++------------ 1 file changed, 14 insertions(+), 24 deletions(-) diff --git a/scripts/ci/assert_opencode_reasoning_effort.py b/scripts/ci/assert_opencode_reasoning_effort.py index cee898619..ea4bd0adb 100644 --- a/scripts/ci/assert_opencode_reasoning_effort.py +++ b/scripts/ci/assert_opencode_reasoning_effort.py @@ -47,39 +47,29 @@ def validate_candidate(config: dict[str, Any], candidate: str) -> list[str]: except ValueError as exc: return [str(exc)] - if not config_for_model and ( - provider == "github-models" or is_known_reasoning_capable(model_name) - ): - return [ - f"OpenCode candidate {candidate} is not defined in opencode.jsonc " - f"under provider {provider}." - ] if not config_for_model: + if provider == "github-models" or is_known_reasoning_capable(model_name): + return [ + f"OpenCode candidate {candidate} is not defined in opencode.jsonc " + f"under provider {provider}." + ] return [] configured_reasoning = config_for_model.get("reasoning") is True - should_require_effort = configured_reasoning or is_known_reasoning_capable(model_name) - if not should_require_effort: + if not (configured_reasoning or is_known_reasoning_capable(model_name)): return [] errors: list[str] = [] + prefix = f"OpenCode reasoning-capable candidate {candidate} must set" + suffix = "in opencode.jsonc." + if not configured_reasoning: - errors.append( - f"OpenCode reasoning-capable candidate {candidate} must set reasoning=true " - "in opencode.jsonc." - ) + errors.append(f"{prefix} reasoning=true {suffix}") if (config_for_model.get("options") or {}).get("reasoningEffort") != "high": - errors.append( - f"OpenCode reasoning-capable candidate {candidate} must set " - "options.reasoningEffort=high in opencode.jsonc." - ) - if ((config_for_model.get("variants") or {}).get("high") or {}).get( - "reasoningEffort" - ) != "high": - errors.append( - f"OpenCode reasoning-capable candidate {candidate} must set " - "variants.high.reasoningEffort=high in opencode.jsonc." - ) + errors.append(f"{prefix} options.reasoningEffort=high {suffix}") + if ((config_for_model.get("variants") or {}).get("high") or {}).get("reasoningEffort") != "high": + errors.append(f"{prefix} variants.high.reasoningEffort=high {suffix}") + return errors From 2733ac752ba9659ffe66c1eff1fb0227a5233241 Mon Sep 17 00:00:00 2001 From: seonghobae <8172694+seonghobae@users.noreply.github.com> Date: Sun, 9 Aug 2026 12:43:33 +0000 Subject: [PATCH 2/9] =?UTF-8?q?=F0=9F=A7=B9=20[=EC=BD=94=EB=93=9C=20?= =?UTF-8?q?=ED=97=AC=EC=8A=A4=20=EA=B0=9C=EC=84=A0]=20validate=5Fcandidate?= =?UTF-8?q?=20=ED=95=A8=EC=88=98=20=EB=A6=AC=ED=8C=A9=ED=86=A0=EB=A7=81?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From f5da593565e888a8280b96ef52ce9d88b5a9954f Mon Sep 17 00:00:00 2001 From: seonghobae <8172694+seonghobae@users.noreply.github.com> Date: Sun, 9 Aug 2026 15:16:16 +0000 Subject: [PATCH 3/9] =?UTF-8?q?=F0=9F=A7=B9=20[=EC=BD=94=EB=93=9C=20?= =?UTF-8?q?=ED=97=AC=EC=8A=A4=20=EA=B0=9C=EC=84=A0]=20validate=5Fcandidate?= =?UTF-8?q?=20=ED=95=A8=EC=88=98=20=EB=A6=AC=ED=8C=A9=ED=86=A0=EB=A7=81?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From 5ab30352fc93b91b097119b0c2809b3c9571fcfd Mon Sep 17 00:00:00 2001 From: seonghobae <8172694+seonghobae@users.noreply.github.com> Date: Tue, 11 Aug 2026 07:12:17 +0000 Subject: [PATCH 4/9] =?UTF-8?q?=F0=9F=A7=B9=20[=EC=BD=94=EB=93=9C=20?= =?UTF-8?q?=ED=97=AC=EC=8A=A4=20=EA=B0=9C=EC=84=A0]=20validate=5Fcandidate?= =?UTF-8?q?=20=ED=95=A8=EC=88=98=20=EB=A6=AC=ED=8C=A9=ED=86=A0=EB=A7=81?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From 21b3c1e39520743427b63954aab3dd27d012db69 Mon Sep 17 00:00:00 2001 From: seonghobae <8172694+seonghobae@users.noreply.github.com> Date: Tue, 11 Aug 2026 07:34:23 +0000 Subject: [PATCH 5/9] =?UTF-8?q?=F0=9F=A7=B9=20[=EC=BD=94=EB=93=9C=20?= =?UTF-8?q?=ED=97=AC=EC=8A=A4=20=EA=B0=9C=EC=84=A0]=20validate=5Fcandidate?= =?UTF-8?q?=20=ED=95=A8=EC=88=98=20=EB=A6=AC=ED=8C=A9=ED=86=A0=EB=A7=81?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From 630373e80b8e6cfe84989b6e98bb643b52f708f8 Mon Sep 17 00:00:00 2001 From: seonghobae <8172694+seonghobae@users.noreply.github.com> Date: Tue, 11 Aug 2026 08:12:42 +0000 Subject: [PATCH 6/9] =?UTF-8?q?=F0=9F=A7=B9=20[=EC=BD=94=EB=93=9C=20?= =?UTF-8?q?=ED=97=AC=EC=8A=A4=20=EA=B0=9C=EC=84=A0]=20validate=5Fcandidate?= =?UTF-8?q?=20=ED=95=A8=EC=88=98=20=EB=A6=AC=ED=8C=A9=ED=86=A0=EB=A7=81?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From 4122456466da134a8eaac9263fb7ef3fcf9e4867 Mon Sep 17 00:00:00 2001 From: seonghobae <8172694+seonghobae@users.noreply.github.com> Date: Tue, 11 Aug 2026 09:07:36 +0000 Subject: [PATCH 7/9] =?UTF-8?q?=F0=9F=A7=B9=20[=EC=BD=94=EB=93=9C=20?= =?UTF-8?q?=ED=97=AC=EC=8A=A4=20=EA=B0=9C=EC=84=A0]=20validate=5Fcandidate?= =?UTF-8?q?=20=ED=95=A8=EC=88=98=20=EB=A6=AC=ED=8C=A9=ED=86=A0=EB=A7=81?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From 492cb3779549843c24388008567a0f640d81787e Mon Sep 17 00:00:00 2001 From: seonghobae <8172694+seonghobae@users.noreply.github.com> Date: Tue, 11 Aug 2026 11:16:01 +0000 Subject: [PATCH 8/9] =?UTF-8?q?=F0=9F=A7=B9=20[=EC=BD=94=EB=93=9C=20?= =?UTF-8?q?=ED=97=AC=EC=8A=A4=20=EA=B0=9C=EC=84=A0]=20validate=5Fcandidate?= =?UTF-8?q?=20=ED=95=A8=EC=88=98=20=EB=A6=AC=ED=8C=A9=ED=86=A0=EB=A7=81?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From ea5dceb60836aaf42a8357b4d5c602f996f389b5 Mon Sep 17 00:00:00 2001 From: seonghobae <8172694+seonghobae@users.noreply.github.com> Date: Tue, 11 Aug 2026 12:28:29 +0000 Subject: [PATCH 9/9] =?UTF-8?q?=F0=9F=A7=B9=20[=EC=BD=94=EB=93=9C=20?= =?UTF-8?q?=ED=97=AC=EC=8A=A4=20=EA=B0=9C=EC=84=A0]=20validate=5Fcandidate?= =?UTF-8?q?=20=ED=95=A8=EC=88=98=20=EB=A6=AC=ED=8C=A9=ED=86=A0=EB=A7=81?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit