From 987192e97f9ba0eb031b88173ab0be37b9ee9735 Mon Sep 17 00:00:00 2001 From: KSSJW <165921128+KSSJW@users.noreply.github.com> Date: Thu, 9 Jul 2026 11:24:06 +0800 Subject: [PATCH 1/2] Refactor: Style of JavaManagementPage --- .../hmcl/ui/main/JavaManagementPage.java | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/HMCL/src/main/java/org/jackhuang/hmcl/ui/main/JavaManagementPage.java b/HMCL/src/main/java/org/jackhuang/hmcl/ui/main/JavaManagementPage.java index 980ee63630..ec119ee3dc 100644 --- a/HMCL/src/main/java/org/jackhuang/hmcl/ui/main/JavaManagementPage.java +++ b/HMCL/src/main/java/org/jackhuang/hmcl/ui/main/JavaManagementPage.java @@ -244,10 +244,10 @@ private static final class JavaItemCell extends ListCell { center.setAlignment(Pos.CENTER_LEFT); label.setAlignment(Pos.CENTER); - label.setMinSize(24, 24); - label.setMaxSize(24, 24); - label.setPrefSize(24, 24); - label.setStyle("-fx-background-color: -monet-secondary-container; -fx-background-radius: 2; -fx-padding: 2; -fx-font-weight: normal; -fx-font-size: 12px;"); + FXUtils.setLimitWidth(label, 32); + FXUtils.setLimitHeight(label, 32); + + label.setStyle("-fx-background-color: -monet-secondary-container; -fx-background-radius: 2; -fx-padding: 2; -fx-font-weight: normal; -fx-font-size: 16px;"); this.content = new TwoLineListItem(); HBox.setHgrow(content, Priority.ALWAYS); @@ -304,15 +304,14 @@ protected void updateItem(JavaRuntime item, boolean empty) { int parsedVersion = item.getParsedVersion(); label.setText(parsedVersion >= 0 ? String.valueOf(parsedVersion) : "?"); - content.setTitle((item.isJDK() ? "JDK" : "JRE") + " " + item.getVersion()); + String vendor = JavaInfo.normalizeVendor(item.getVendor()); + + content.setTitle((vendor != null ? vendor : "Unknown") + " " + (item.isJDK() ? "JDK" : "JRE") + " " + item.getVersion()); content.setSubtitle(item.getBinary().toString()); if (oldItem != item) { content.getTags().clear(); - content.addTag(i18n("java.info.architecture") + ": " + item.getArchitecture().getDisplayName()); - String vendor = JavaInfo.normalizeVendor(item.getVendor()); - if (vendor != null) - content.addTag(i18n("java.info.vendor") + ": " + vendor); + content.addTag(item.getArchitecture().getDisplayName()); } SVG newRemoveIcon = item.isManaged() ? SVG.DELETE_FOREVER : SVG.DELETE; From 89f38de6ceb52b58891fbd4e7193667efab90622 Mon Sep 17 00:00:00 2001 From: KSSJW <165921128+KSSJW@users.noreply.github.com> Date: Sat, 11 Jul 2026 02:16:16 +0800 Subject: [PATCH 2/2] Chore: I18n for unknown --- .../java/org/jackhuang/hmcl/ui/main/JavaManagementPage.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/HMCL/src/main/java/org/jackhuang/hmcl/ui/main/JavaManagementPage.java b/HMCL/src/main/java/org/jackhuang/hmcl/ui/main/JavaManagementPage.java index ec119ee3dc..5f0946582d 100644 --- a/HMCL/src/main/java/org/jackhuang/hmcl/ui/main/JavaManagementPage.java +++ b/HMCL/src/main/java/org/jackhuang/hmcl/ui/main/JavaManagementPage.java @@ -306,7 +306,7 @@ protected void updateItem(JavaRuntime item, boolean empty) { String vendor = JavaInfo.normalizeVendor(item.getVendor()); - content.setTitle((vendor != null ? vendor : "Unknown") + " " + (item.isJDK() ? "JDK" : "JRE") + " " + item.getVersion()); + content.setTitle((vendor != null ? vendor : i18n("message.unknown")) + " " + (item.isJDK() ? "JDK" : "JRE") + " " + item.getVersion()); content.setSubtitle(item.getBinary().toString()); if (oldItem != item) {