You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The fix for #75 updated the code and JSON schema correctly, but did not update the design document.
What needs to change in docs/design/notifications.md
Line 36 - Remove "Persisted per-tab in the user-computer-profile entity." from the IsSnoozed docstring. Replace with "Snooze state is in-memory only and resets on restart."
Lines 159-160 - Remove the persistence paragraph in the Snooze section:
"Snooze state is persisted per tab key in the user-computer-profile entity under a snoozed-notification-tabs string array field."
Line 264 - In Non-goals Bump actions/checkout from 4 to 7 #1, change "snooze state is persisted" to "snooze state is not persisted" (or rewrite to clarify it resets on restart).
Why
Issue #75 required removing all design-doc references to persisting snooze state, but the commit only modified the schema file and a code comment. The design doc is the authoritative spec and still documents the wrong behaviour.
Summary
The fix for #75 updated the code and JSON schema correctly, but did not update the design document.
What needs to change in docs/design/notifications.md
Line 36 - Remove "Persisted per-tab in the user-computer-profile entity." from the IsSnoozed docstring. Replace with "Snooze state is in-memory only and resets on restart."
Lines 159-160 - Remove the persistence paragraph in the Snooze section:
Line 259 - Remove the file checklist entry:
Line 264 - In Non-goals Bump actions/checkout from 4 to 7 #1, change "snooze state is persisted" to "snooze state is not persisted" (or rewrite to clarify it resets on restart).
Why
Issue #75 required removing all design-doc references to persisting snooze state, but the commit only modified the schema file and a code comment. The design doc is the authoritative spec and still documents the wrong behaviour.