From a3732a9358b8b83cc2a2498239884853a17b8012 Mon Sep 17 00:00:00 2001 From: cnathe Date: Mon, 29 Jun 2026 14:23:56 -0500 Subject: [PATCH 1/2] GitHub Issue 1219: DataRegion call to saveQueryViews does not need to include view 'fields' info in post --- api/webapp/clientapi/dom/DataRegion.js | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/api/webapp/clientapi/dom/DataRegion.js b/api/webapp/clientapi/dom/DataRegion.js index cfc89dd65dc..9d1bec6f415 100644 --- a/api/webapp/clientapi/dom/DataRegion.js +++ b/api/webapp/clientapi/dom/DataRegion.js @@ -2889,6 +2889,15 @@ if (!LABKEY.DataRegions) { session: true }); + // GitHub Issue 1219: the view 'fields' column-metadata is never used on save so can be removed from payload + // and only fieldKey/title are read per column trim down that as well + delete viewConfig.fields; + if (LABKEY.Utils.isArray(viewConfig.columns)) { + viewConfig.columns = $.map(viewConfig.columns, function(col) { + return col.title ? { fieldKey: col.fieldKey, title: col.title } : { fieldKey: col.fieldKey }; + }); + } + LABKEY.Query.saveQueryViews({ containerPath: this.containerPath, schemaName: this.schemaName, From 8ff06aaaf97179c4631554f1adc0f3a1a620ff2f Mon Sep 17 00:00:00 2001 From: cnathe Date: Wed, 1 Jul 2026 07:35:32 -0500 Subject: [PATCH 2/2] update comment --- api/webapp/clientapi/dom/DataRegion.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/api/webapp/clientapi/dom/DataRegion.js b/api/webapp/clientapi/dom/DataRegion.js index 9d1bec6f415..7cea7215eef 100644 --- a/api/webapp/clientapi/dom/DataRegion.js +++ b/api/webapp/clientapi/dom/DataRegion.js @@ -2889,8 +2889,8 @@ if (!LABKEY.DataRegions) { session: true }); - // GitHub Issue 1219: the view 'fields' column-metadata is never used on save so can be removed from payload - // and only fieldKey/title are read per column trim down that as well + // GitHub Issue 1219: the 'fields' column-metadata for the view is never used on the server-side save action + // so it can be removed from the payload. Also, only fieldKey/title are read per column so we can trim down that as well. delete viewConfig.fields; if (LABKEY.Utils.isArray(viewConfig.columns)) { viewConfig.columns = $.map(viewConfig.columns, function(col) {