refactor: drop registrations that nothing resolves

Each of these was registered at boot and never resolved: no `$name`
constructor parameter, no resolve()/get() call, no dynamic lookup.

- wp8EmulatorServices: resolveEmulatorServices() branches on iOS and
  Android only, so the Windows Phone 8 stub was unreachable
- networkConnectivityValidator, qrCodeTerminalService, qr
- dispatcher (FutureDispatcher), which orphaned common/queue.ts;
  commandDispatcher in the same file stays, it drives the CLI entry point
- swaggerBlock, swaggerLine, swaggerCodePrinter — registrations only.
  message-contract-generator imports and news these classes directly, so
  the classes stay.

Also removes the requirePublicClass("localBuildService", …) line, whose
target file does not exist. The lazy require meant it only threw if
something resolved the name, and nothing ever did.

constants was surveyed as dead too, but it is live: requirePublicClass
exposes it as require("nativescript").constants, which the public API
test asserts on. Kept.

Author: edusperoni

lib/bootstrap.ts

@@ -309,10 +309,6 @@ injector.require("deployCommandHelper", "./helpers/deploy-command-helper");
 injector.require("platformCommandHelper", "./helpers/platform-command-helper");
 injector.require("optionsTracker", "./helpers/options-track-helper");
 
-injector.requirePublicClass(
-	"localBuildService",
-	"./services/local-build-service",
-);
 injector.require("LiveSyncSocket", "./services/livesync/livesync-socket");
 injector.requirePublicClass(
 	"androidLivesyncTool",
@@ -412,19 +408,11 @@ injector.require(
 injector.require("hmrStatusService", "./services/hmr-status-service");
 
 injector.require("pacoteService", "./services/pacote-service");
-injector.require(
-	"qrCodeTerminalService",
-	"./services/qr-code-terminal-service",
-);
 injector.require(
 	"testInitializationService",
 	"./services/test-initialization-service",
 );
 
-injector.require(
-	"networkConnectivityValidator",
-	"./helpers/network-connectivity-validator",
-);
 injector.requirePublic("cleanupService", "./services/cleanup-service");
 
 injector.require(

lib/common/bootstrap.ts

@@ -9,7 +9,6 @@ injector.requirePublic("fs", "./file-system");
 injector.require("hostInfo", "./host-info");
 injector.require("osInfo", "./os-info");
 
-injector.require("dispatcher", "./dispatchers");
 injector.require("commandDispatcher", "./dispatchers");
 
 injector.require("resources", "./resource-loader");
@@ -42,112 +41,111 @@ injector.requireCommand("autocomplete|status", "./commands/autocompletion");
 
 injector.requireCommand(
 	["device|*list", "devices|*list"],
-	"./commands/device/list-devices"
+	"./commands/device/list-devices",
 );
 injector.requireCommand(
 	["device|android", "devices|android"],
-	"./commands/device/list-devices"
+	"./commands/device/list-devices",
 );
 injector.requireCommand(
 	["device|ios", "devices|ios"],
-	"./commands/device/list-devices"
+	"./commands/device/list-devices",
 );
 
 injector.requireCommand("device|log", "./commands/device/device-log-stream");
 injector.requireCommand("device|run", "./commands/device/run-application");
 injector.requireCommand("device|stop", "./commands/device/stop-application");
 injector.requireCommand(
 	"device|list-applications",
-	"./commands/device/list-applications"
+	"./commands/device/list-applications",
 );
 injector.requireCommand(
 	"device|uninstall",
-	"./commands/device/uninstall-application"
+	"./commands/device/uninstall-application",
 );
 injector.requireCommand("device|list-files", "./commands/device/list-files");
 injector.requireCommand("device|get-file", "./commands/device/get-file");
 injector.requireCommand("device|put-file", "./commands/device/put-file");
 
 injector.require(
 	"iosDeviceOperations",
-	"./mobile/ios/device/ios-device-operations"
+	"./mobile/ios/device/ios-device-operations",
 );
 
 injector.require("deviceDiscovery", "./mobile/mobile-core/device-discovery");
 injector.require(
 	"iOSDeviceDiscovery",
-	"./mobile/mobile-core/ios-device-discovery"
+	"./mobile/mobile-core/ios-device-discovery",
 );
 injector.require(
 	"iOSSimulatorDiscovery",
-	"./mobile/mobile-core/ios-simulator-discovery"
+	"./mobile/mobile-core/ios-simulator-discovery",
 );
 injector.require(
 	"androidDeviceDiscovery",
-	"./mobile/mobile-core/android-device-discovery"
+	"./mobile/mobile-core/android-device-discovery",
 );
 injector.require(
 	"androidEmulatorDiscovery",
-	"./mobile/mobile-core/android-emulator-discovery"
+	"./mobile/mobile-core/android-emulator-discovery",
 );
 injector.require("iOSDevice", "./mobile/ios/device/ios-device");
 injector.require(
 	"iOSDeviceProductNameMapper",
-	"./mobile/ios/ios-device-product-name-mapper"
+	"./mobile/ios/ios-device-product-name-mapper",
 );
 injector.require("androidDevice", "./mobile/android/android-device");
 injector.require("adb", "./mobile/android/android-debug-bridge");
 injector.require(
 	"androidDebugBridgeResultHandler",
-	"./mobile/android/android-debug-bridge-result-handler"
+	"./mobile/android/android-debug-bridge-result-handler",
 );
 injector.require(
 	"androidVirtualDeviceService",
-	"./mobile/android/android-virtual-device-service"
+	"./mobile/android/android-virtual-device-service",
 );
 injector.require(
 	"androidIniFileParser",
-	"./mobile/android/android-ini-file-parser"
+	"./mobile/android/android-ini-file-parser",
 );
 injector.require(
 	"androidGenymotionService",
-	"./mobile/android/genymotion/genymotion-service"
+	"./mobile/android/genymotion/genymotion-service",
 );
 injector.require(
 	"virtualBoxService",
-	"./mobile/android/genymotion/virtualbox-service"
+	"./mobile/android/genymotion/virtualbox-service",
 );
 injector.require("logcatHelper", "./mobile/android/logcat-helper");
 injector.require("iOSSimResolver", "./mobile/ios/simulator/ios-sim-resolver");
 injector.require(
 	"iOSSimulatorLogProvider",
-	"./mobile/ios/simulator/ios-simulator-log-provider"
+	"./mobile/ios/simulator/ios-simulator-log-provider",
 );
 
 injector.require(
 	"localToDevicePathDataFactory",
-	"./mobile/local-to-device-path-data-factory"
+	"./mobile/local-to-device-path-data-factory",
 );
 
 injector.requirePublic(
 	"devicesService",
-	"./mobile/mobile-core/devices-service"
+	"./mobile/mobile-core/devices-service",
 );
 injector.requirePublic(
 	"androidProcessService",
-	"./mobile/mobile-core/android-process-service"
+	"./mobile/mobile-core/android-process-service",
 );
 injector.require("projectNameValidator", "./validators/project-name-validator");
 
 injector.require(
 	"androidEmulatorServices",
-	"./mobile/android/android-emulator-services"
+	"./mobile/android/android-emulator-services",
 );
 injector.require(
 	"iOSEmulatorServices",
-	"./mobile/ios/simulator/ios-emulator-services"
+	"./mobile/ios/simulator/ios-emulator-services",
 );
-injector.require("wp8EmulatorServices", "./mobile/wp8/wp8-emulator-services");
 
 injector.require("autoCompletionService", "./services/auto-completion-service");
 injector.requirePublic("settingsService", "./services/settings-service");
@@ -157,18 +155,18 @@ injector.require("mobileHelper", "./mobile/mobile-helper");
 injector.require("emulatorHelper", "./mobile/emulator-helper");
 injector.require(
 	"devicePlatformsConstants",
-	"./mobile/device-platforms-constants"
+	"./mobile/device-platforms-constants",
 );
 injector.require("helpService", "./services/help-service");
 injector.require(
 	"messageContractGenerator",
-	"./services/message-contract-generator"
+	"./services/message-contract-generator",
 );
 injector.require("proxyService", "./services/proxy-service");
 injector.requireCommand("dev-preuninstall", "./commands/preuninstall");
 injector.requireCommand(
 	"dev-generate-messages",
-	"./commands/generate-messages"
+	"./commands/generate-messages",
 );
 injector.requireCommand("doctor|*all", "./commands/doctor");
 injector.requireCommand("doctor|ios", "./commands/doctor");
@@ -190,5 +188,4 @@ injector.require("projectFilesManager", "./services/project-files-manager");
 injector.require("xcodeSelectService", "./services/xcode-select-service");
 injector.require("net", "./services/net-service");
 
-injector.require("qr", "./services/qr");
 injector.require(["lockfile", "lockService"], "./services/lock-service");

lib/common/codeGeneration/code-entity.ts

@@ -1,5 +1,4 @@
 import * as _ from "lodash";
-import { injector } from "../yok";
 import { CodeGeneration } from "./code-generation";
 
 export enum CodeEntityType {
@@ -22,7 +21,6 @@ export class Line implements CodeGeneration.ILine {
 		return new Line(content);
 	}
 }
-injector.register("swaggerLine", Line);
 
 export class Block implements CodeGeneration.IBlock {
 	public opener: string;
@@ -55,4 +53,3 @@ export class Block implements CodeGeneration.IBlock {
 		this.codeEntities.push(line);
 	}
 }
-injector.register("swaggerBlock", Block);

lib/common/codeGeneration/code-printer.ts

@@ -2,7 +2,6 @@ import * as _ from "lodash";
 import { EOL } from "os";
 import { CodeEntityType } from "./code-entity";
 import { CodeGeneration } from "./code-generation";
-import { injector } from "../yok";
 
 export class CodePrinter {
 	private static INDENT_CHAR = "\t";
@@ -12,7 +11,7 @@ export class CodePrinter {
 
 	public composeBlock(
 		block: CodeGeneration.IBlock,
-		indentSize?: number
+		indentSize?: number,
 	): string {
 		indentSize = indentSize === undefined ? 0 : indentSize;
 		let content = this.getIndentation(indentSize);
@@ -27,12 +26,12 @@ export class CodePrinter {
 			if (codeEntity.codeEntityType === CodeEntityType.Line) {
 				content += this.composeLine(
 					<CodeGeneration.ILine>codeEntity,
-					indentSize + 1
+					indentSize + 1,
 				);
 			} else if (codeEntity.codeEntityType === CodeEntityType.Block) {
 				content += this.composeBlock(
 					<CodeGeneration.IBlock>codeEntity,
-					indentSize + 1
+					indentSize + 1,
 				);
 			}
 		});
@@ -59,4 +58,3 @@ export class CodePrinter {
 		return content;
 	}
 }
-injector.register("swaggerCodePrinter", CodePrinter);

lib/common/declarations.d.ts

@@ -270,11 +270,6 @@ interface ICommandOptions {
 	disableCommandHelpSuggestion?: boolean;
 }
 
-interface IFutureDispatcher {
-	run(): void;
-	dispatch(action: () => Promise<void>): void;
-}
-
 interface ICommandDispatcher {
 	dispatchCommand(): Promise<void>;
 }
@@ -284,11 +279,6 @@ interface ICancellationService extends IDisposable {
 	end(name: string): void;
 }
 
-interface IQueue<T> {
-	enqueue(item: T): void;
-	dequeue(): Promise<T>;
-}
-
 interface IChildProcess extends ChildProcess {}
 
 interface IExecOptions {
@@ -558,10 +548,6 @@ interface IProxyService {
 	getInfo(): Promise<string>;
 }
 
-interface IQrCodeGenerator {
-	generateDataUri(data: string): Promise<string>;
-}
-
 interface IQrCodeImageData {
 	/**
 	 * The original URL used for generating QR code image.

lib/common/dispatchers.ts

@@ -1,14 +1,10 @@
 import * as _ from "lodash";
-import * as queue from "./queue";
 import * as path from "path";
 import { hook } from "./helpers";
 import {
 	ICommandDispatcher,
 	ICancellationService,
 	ISysInfo,
-	IFutureDispatcher,
-	IQueue,
-	IErrors,
 } from "./declarations";
 import { IOptions, IPackageManager, IVersionsService } from "../declarations";
 import { IInjector } from "./definitions/yok";
@@ -29,7 +25,7 @@ export class CommandDispatcher implements ICommandDispatcher {
 		private $options: IOptions,
 		private $versionsService: IVersionsService,
 		private $packageManager: IPackageManager,
-		private $terminalSpinnerService: ITerminalSpinnerService
+		private $terminalSpinnerService: ITerminalSpinnerService,
 	) {}
 
 	public async dispatchCommand(): Promise<void> {
@@ -45,7 +41,7 @@ export class CommandDispatcher implements ICommandDispatcher {
 					__dirname,
 					"..",
 					"..",
-					"package.json"
+					"package.json",
 				),
 			});
 			this.$logger.trace("System information:");
@@ -76,15 +72,15 @@ export class CommandDispatcher implements ICommandDispatcher {
 
 		await this.$commandsService.tryExecuteCommand(
 			commandName,
-			commandArguments
+			commandArguments,
 		);
 	}
 
 	@hook("resolveCommand")
 	private async resolveCommand(
 		commandName: string,
 		commandArguments: string[],
-		argv: string[]
+		argv: string[],
 	) {
 		// just a hook point
 		return { commandName, commandArguments, argv };
@@ -142,39 +138,16 @@ export class CommandDispatcher implements ICommandDispatcher {
 				nativescriptCliVersion.latestVersion,
 				{
 					loose: true,
-				}
+				},
 			)
 		) {
 			// up-to-date
 			spinner.succeed("Up to date.");
 		} else {
 			spinner.info(
-				`New version of NativeScript CLI is available (${nativescriptCliVersion.latestVersion}), run '${updateCommand}' to update.`
+				`New version of NativeScript CLI is available (${nativescriptCliVersion.latestVersion}), run '${updateCommand}' to update.`,
 			);
 		}
 	}
 }
 injector.register("commandDispatcher", CommandDispatcher);
-
-class FutureDispatcher implements IFutureDispatcher {
-	private actions: IQueue<any>;
-
-	public constructor(private $errors: IErrors) {}
-
-	public async run(): Promise<void> {
-		if (this.actions) {
-			this.$errors.fail("You cannot run a running future dispatcher.");
-		}
-		this.actions = new queue.Queue<any>();
-
-		while (true) {
-			const action = await this.actions.dequeue();
-			await action();
-		}
-	}
-
-	public dispatch(action: () => Promise<void>) {
-		this.actions.enqueue(action);
-	}
-}
-injector.register("dispatcher", FutureDispatcher, false);