From 3cde3402336ac50f224571cd20e001a6519d3319 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ralph=20K=C3=BCpper?= Date: Sun, 2 Aug 2026 17:04:32 +0200 Subject: [PATCH] test(gc): register the dark call-argument witness from #7252 --- changelog.d/7263-register-dark-call-arg-witness.md | 9 +++++++++ test-parity/gc_repsel_corpus.txt | 10 ++++++++++ 2 files changed, 19 insertions(+) create mode 100644 changelog.d/7263-register-dark-call-arg-witness.md diff --git a/changelog.d/7263-register-dark-call-arg-witness.md b/changelog.d/7263-register-dark-call-arg-witness.md new file mode 100644 index 0000000000..49f5dac2f9 --- /dev/null +++ b/changelog.d/7263-register-dark-call-arg-witness.md @@ -0,0 +1,9 @@ +`test_gap_gc_call_argument_rooting` shipped with #7252 but was never added to +`test-parity/gc_repsel_corpus.txt`, so it never ran anywhere. Registering it is +the whole fix. + +This is the third occurrence of the same mistake (#7192 and #7216 are documented +in that file directly above), and the first one caught automatically: the +`test_gap_gc_*` enforcement added in response to the earlier two failed the +`GC Moving Witnesses` job on its first main-line run — which only happened at +all because #7253 gave that matrix a main-line trigger. diff --git a/test-parity/gc_repsel_corpus.txt b/test-parity/gc_repsel_corpus.txt index cb626e7ead..4ea39a54a6 100644 --- a/test-parity/gc_repsel_corpus.txt +++ b/test-parity/gc_repsel_corpus.txt @@ -286,6 +286,16 @@ test_gap_gc_closure_call_callee_rooting test_gap_gc_closure_call_this_rooting test_gap_gc_closure_call_argument_rooting +# --- A THIRD witness that was registered nowhere (#7252) -------------------- +# `test_gap_gc_call_argument_rooting` shipped with #7252 (cross-module direct +# call argument rooting, authored by @jdalton, restacked at merge). Same defect +# as #7192 and #7216 above: the PR added the witness and did not add the line. +# It was dark from merge until the `test_gap_gc_*` enforcement added for those +# two caught it on the first `GC Moving Witnesses` run on main -- which is the +# enforcement working exactly as designed, on the third occurrence of the same +# mistake. Registering the file is the whole fix. +test_gap_gc_call_argument_rooting + # --- Two witnesses that were registered nowhere (#7192, #7216) --------------- # Both files exist in test-files/, both say in their own headers that they are # LIVE BY CONSTRUCTION and bite only on the moving arms, and neither was in this