refactor: clarify room palette cache handling

Author: tubededentifrice

roborock/map/map_parser.py

@@ -128,8 +128,10 @@ def parse(
     ):
         """Assign non-conflicting room colors before the V1 image pass."""
         with self._palette_lock:
-            self._room_palette.cached_room_colors.clear()
-            self._room_palette.cached_room_colors.update(self._base_room_colors)
+            # cached_room_colors is a read-only property, so reset its dict in place.
+            cached_room_colors = self._room_palette.cached_room_colors
+            cached_room_colors.clear()
+            cached_room_colors.update(self._base_room_colors)
 
             if self._recolor_rooms:
 
@@ -140,8 +142,9 @@ def room_id(value: int) -> int | None:
 
                 room_colors = adjacency_aware_room_colors(raw_data, width, self._room_palette, room_id)
                 for number, color in room_colors.items():
-                    self._room_palette.cached_room_colors[number] = color
-                    self._room_palette.cached_room_colors[str(number)] = color
+                    # ColorsPalette caches both forms for get_room_color(str | int).
+                    cached_room_colors[number] = color
+                    cached_room_colors[str(number)] = color
             return super().parse(raw_data, width, height, carpet_map, removed_map)
 
 

tests/map/test_map_parser.py

@@ -36,6 +36,7 @@ def test_v1_parser_gives_adjacent_rooms_distinct_palette_colors() -> None:
 
     assert image is not None
     assert image.getpixel((0, 0)) != image.getpixel((1, 0))
+    assert palette.get_room_color(12) == palette.get_room_color("12")
 
     isolated_image, _rooms = image_parser.parse(bytes([(12 << 3) | 7]), 1, 1, None)