From 0e781ac45907fb441c26a1730b0b89868917f3d8 Mon Sep 17 00:00:00 2001
From: "google-labs-jules[bot]"
 <161369871+google-labs-jules[bot]@users.noreply.github.com>
Date: Tue, 11 Aug 2026 21:49:56 +0000
Subject: [PATCH] perf: avoid intermediate string allocations in SQL generation

Co-authored-by: SayanthRock <202829406+SayanthRock@users.noreply.github.com>
---
 compiler/rockql-sql/src/lib.rs | 34 ++++++++++++++++++++++++++--------
 1 file changed, 26 insertions(+), 8 deletions(-)

diff --git a/compiler/rockql-sql/src/lib.rs b/compiler/rockql-sql/src/lib.rs
index 34a76b9..aac1139 100644
--- a/compiler/rockql-sql/src/lib.rs
+++ b/compiler/rockql-sql/src/lib.rs
@@ -24,13 +24,19 @@ impl FromStr for Dialect {
     type Err = String;
 
     fn from_str(value: &str) -> Result<Self, Self::Err> {
-        match value.to_ascii_lowercase().as_str() {
-            "generic" | "sql" => Ok(Self::Generic),
-            "sqlite" | "sqlite3" => Ok(Self::Sqlite),
-            "postgres" | "postgresql" => Ok(Self::Postgres),
-            _ => Err(format!(
+        // ⚡ Bolt Optimization: Use `eq_ignore_ascii_case` to avoid allocating
+        // a new String via `to_ascii_lowercase()` on every call.
+        if value.eq_ignore_ascii_case("generic") || value.eq_ignore_ascii_case("sql") {
+            Ok(Self::Generic)
+        } else if value.eq_ignore_ascii_case("sqlite") || value.eq_ignore_ascii_case("sqlite3") {
+            Ok(Self::Sqlite)
+        } else if value.eq_ignore_ascii_case("postgres") || value.eq_ignore_ascii_case("postgresql")
+        {
+            Ok(Self::Postgres)
+        } else {
+            Err(format!(
                 "unsupported SQL target `{value}`; expected generic, sqlite, or postgres"
-            )),
+            ))
         }
     }
 }
@@ -119,13 +125,25 @@ pub fn compile(query: &Query, dialect: Dialect) -> Result<String, SqlError> {
 
     if !filters.is_empty() {
         sql.push_str("WHERE ");
-        sql.push_str(&filters.join("\n  AND "));
+        // ⚡ Bolt Optimization: Avoid allocating an intermediate String from `.join()`
+        for (index, filter) in filters.iter().enumerate() {
+            sql.push_str(filter);
+            if index + 1 < filters.len() {
+                sql.push_str("\n  AND ");
+            }
+        }
         sql.push('\n');
     }
 
     if !sort_items.is_empty() {
         sql.push_str("ORDER BY ");
-        sql.push_str(&sort_items.join(", "));
+        // ⚡ Bolt Optimization: Avoid allocating an intermediate String from `.join()`
+        for (index, item) in sort_items.iter().enumerate() {
+            sql.push_str(item);
+            if index + 1 < sort_items.len() {
+                sql.push_str(", ");
+            }
+        }
         sql.push('\n');
     }