Inline lua.SyntaxKind as a build-time constant

Author: ark120202

package.json

@@ -44,7 +44,6 @@
         "fengari-web": "^0.1.4",
         "highlight.js": "^9.18.0",
         "monaco-editor": "^0.19.3",
-        "node-libs-browser": "^2.2.1",
         "renderjson": "^1.4.0",
         "typescript-to-lua": "^0.31.0"
     }

src/playground/index.ts

@@ -4,7 +4,6 @@ import "monaco-editor/esm/vs/basic-languages/typescript/typescript.contribution"
 import "monaco-editor/esm/vs/editor/edcore.main";
 import "monaco-editor/esm/vs/language/typescript/monaco.contribution";
 import renderjson from "renderjson";
-import * as lua from "typescript-to-lua/dist/LuaAST";
 import { version as tstlVersion } from "typescript-to-lua/package.json";
 import EditorWorker from "worker-loader?name=editor.worker.js!monaco-editor/esm/vs/editor/editor.worker.js";
 import FengariWorker from "worker-loader?name=fengari.worker.js!./fengari.worker";
@@ -14,6 +13,7 @@ import { getInitialCode, updateCodeHistory } from "./code";
 
 // TODO: Use TypeScript 3.8 type imports
 type CustomTypeScriptWorker = import("./ts.worker").CustomTypeScriptWorker;
+type LuaBlock = import("typescript-to-lua/dist/LuaAST").Block;
 
 (globalThis as any).MonacoEnvironment = {
     getWorker(_workerId: any, label: string) {
@@ -25,10 +25,11 @@ type CustomTypeScriptWorker = import("./ts.worker").CustomTypeScriptWorker;
     },
 };
 
+const LuaSyntaxKind = __LUA_SYNTAX_KIND__;
 renderjson.set_show_to_level(1);
 renderjson.set_replacer((key: string, value: any) => {
     if (key === "kind") {
-        return lua.SyntaxKind[value];
+        return LuaSyntaxKind[value];
     }
 
     return value;
@@ -56,7 +57,7 @@ const onTabClick = () => {
 luaTabText.onclick = onTabClick;
 luaTabAst.onclick = onTabClick;
 
-function setLuaAST(ast: lua.Block) {
+function setLuaAST(ast: LuaBlock) {
     luaAstContainer.innerText = "";
     luaAstContainer.appendChild(renderjson(ast));
 }

src/types.d.ts

@@ -8,3 +8,5 @@ declare module "worker-loader*" {
 
     export = WebpackWorker;
 }
+
+declare const __LUA_SYNTAX_KIND__: typeof import("typescript-to-lua").SyntaxKind;

webpack.config.js

@@ -2,9 +2,10 @@ const webpack = require("webpack");
 const path = require("path");
 const HtmlWebpackPlugin = require("html-webpack-plugin");
 const PnpWebpackPlugin = require("pnp-webpack-plugin");
+// Not used directly in playground, because it imports typescript
+const { SyntaxKind: LuaSyntaxKind } = require("typescript-to-lua/dist/LuaAST");
 
 const resolve = query => path.resolve(__dirname, query);
-const emptyModulePath = require.resolve("node-libs-browser/mock/empty.js");
 
 /** @type {import("webpack").Configuration} */
 module.exports = {
@@ -18,6 +19,12 @@ module.exports = {
     resolve: {
         extensions: [".tsx", ".ts", ".js"],
         plugins: [PnpWebpackPlugin],
+        alias: {
+            // Replace vendored `monaco-typescript` services build with `typescript`, already used by `typescript-to-lua`
+            [require.resolve("monaco-editor/esm/vs/language/typescript/lib/typescriptServices.js")]: require.resolve(
+                "typescript",
+            ),
+        },
     },
     resolveLoader: {
         plugins: [PnpWebpackPlugin.moduleLoader(module)],
@@ -53,23 +60,9 @@ module.exports = {
             contentFile: "play.html",
         }),
 
-        // Ignore pnpapi reference in patched typescript source
-        new webpack.IgnorePlugin(/pnpapi/),
-
-        new webpack.NormalModuleReplacementPlugin(/typescript/, resource => {
-            // Exclude `typescript` from `play_bundle` referenced from `typescript-to-lua/dist/LuaAST`
-            const { issuer, compiler } = (resource.resourceResolveData && resource.resourceResolveData.context) || {};
-            if (issuer === require.resolve("typescript-to-lua/dist/LuaAST") && compiler !== "worker") {
-                resource.resource = emptyModulePath;
-            }
+        new webpack.DefinePlugin({ __LUA_SYNTAX_KIND__: JSON.stringify(LuaSyntaxKind) }),
 
-            // Replace vendored monaco-typescript's services build with full TypeScript API.
-            if (
-                resource.resource ===
-                require.resolve("monaco-editor/esm/vs/language/typescript/lib/typescriptServices.js")
-            ) {
-                resource.request = require.resolve("typescript");
-            }
-        }),
+        // Ignore `pnpapi` reference in patched `typescript` source
+        new webpack.IgnorePlugin(/pnpapi/),
     ],
 };

yarn.lock

@@ -6340,7 +6340,6 @@ resolve@^1.13.1:
     html-loader: ^0.5.5
     html-webpack-plugin: ^3.2.0
     monaco-editor: ^0.19.3
-    node-libs-browser: ^2.2.1
     pnp-webpack-plugin: ^1.5.0
     prettier: ^1.19.1
     raw-loader: ^4.0.0