From d9e7fbb0d746fb70b7b89661504c3f9125fd8cb7 Mon Sep 17 00:00:00 2001
From: Dimitrios Pantazis <dpanta94@gmail.com>
Date: Sun, 16 Aug 2026 10:04:30 -0700
Subject: [PATCH 1/2] feat: removes 4 phpstan baseline files and fixes their
 errors

More specifically removes baselines deadCode.unreachable.neon, if.alwaysTrue.neon, while.alwaysFalse.neon and while.alwaysTrue.neon
---
 phpstan.neon.dist                             |   2 -
 .../themes/twentyfourteen/inc/widgets.php     |   2 +-
 src/wp-includes/class-wp-query.php            |   4 +
 src/wp-includes/query.php                     |   4 +
 .../baselines/deadCode.unreachable.neon       | 230 --------------
 tests/phpstan/baselines/if.alwaysTrue.neon    |   5 -
 .../phpstan/baselines/while.alwaysFalse.neon  |  25 --
 tests/phpstan/baselines/while.alwaysTrue.neon | 300 ------------------
 8 files changed, 9 insertions(+), 563 deletions(-)
 delete mode 100644 tests/phpstan/baselines/while.alwaysFalse.neon
 delete mode 100644 tests/phpstan/baselines/while.alwaysTrue.neon

diff --git a/phpstan.neon.dist b/phpstan.neon.dist
index e2e72fb367482..94c8716f3dd65 100644
--- a/phpstan.neon.dist
+++ b/phpstan.neon.dist
@@ -88,8 +88,6 @@ includes:
 	- tests/phpstan/baselines/ternary.alwaysTrue.neon
 	- tests/phpstan/baselines/varTag.noVariable.neon
 	- tests/phpstan/baselines/variable.undefined.neon
-	- tests/phpstan/baselines/while.alwaysFalse.neon
-	- tests/phpstan/baselines/while.alwaysTrue.neon
 	# phpstan:baselines end
 
 parameters:
diff --git a/src/wp-content/themes/twentyfourteen/inc/widgets.php b/src/wp-content/themes/twentyfourteen/inc/widgets.php
index 36846daa84860..7ee2991d91b37 100644
--- a/src/wp-content/themes/twentyfourteen/inc/widgets.php
+++ b/src/wp-content/themes/twentyfourteen/inc/widgets.php
@@ -137,6 +137,7 @@ public function widget( $args, $instance ) {
 		if ( $ephemera->have_posts() ) :
 			$tmp_content_width        = $GLOBALS['content_width'];
 			$GLOBALS['content_width'] = 306;
+			$tmp_more                 = $GLOBALS['more'];
 
 			echo $args['before_widget'];
 			?>
@@ -148,7 +149,6 @@ public function widget( $args, $instance ) {
 				<?php
 				while ( $ephemera->have_posts() ) :
 					$ephemera->the_post();
-					$tmp_more        = $GLOBALS['more'];
 					$GLOBALS['more'] = 0;
 					?>
 				<li>
diff --git a/src/wp-includes/class-wp-query.php b/src/wp-includes/class-wp-query.php
index 228691d26d12b..906cca0905e1a 100644
--- a/src/wp-includes/class-wp-query.php
+++ b/src/wp-includes/class-wp-query.php
@@ -3839,6 +3839,8 @@ function ( $carry, $post ) {
 	 *
 	 * @since 1.5.0
 	 *
+	 * @phpstan-impure
+	 *
 	 * @return bool True if posts are available, false if end of the loop.
 	 */
 	public function have_posts() {
@@ -3929,6 +3931,8 @@ public function the_comment() {
 	 *
 	 * @since 2.2.0
 	 *
+	 * @phpstan-impure
+	 *
 	 * @return bool True if comments are available, false if no more comments.
 	 */
 	public function have_comments() {
diff --git a/src/wp-includes/query.php b/src/wp-includes/query.php
index 60571c01cb880..42592002c1cab 100644
--- a/src/wp-includes/query.php
+++ b/src/wp-includes/query.php
@@ -956,6 +956,8 @@ function is_main_query() {
  *
  * @global WP_Query $wp_query WordPress Query object.
  *
+ * @phpstan-impure
+ *
  * @return bool True if posts are available, false if end of the loop.
  */
 function have_posts() {
@@ -1036,6 +1038,8 @@ function the_post() {
  *
  * @global WP_Query $wp_query WordPress Query object.
  *
+ * @phpstan-impure
+ *
  * @return bool True if comments are available, false if no more comments.
  */
 function have_comments() {
diff --git a/tests/phpstan/baselines/deadCode.unreachable.neon b/tests/phpstan/baselines/deadCode.unreachable.neon
index 0bd31fe524a9a..8a4288bc40c43 100644
--- a/tests/phpstan/baselines/deadCode.unreachable.neon
+++ b/tests/phpstan/baselines/deadCode.unreachable.neon
@@ -38,241 +38,11 @@ parameters:
 			identifier: deadCode.unreachable
 			count: 1
 			path: ../../../src/wp-admin/includes/class-wp-internal-pointers.php
-		-
-			message: '#^Unreachable statement \- code above always terminates\.$#'
-			identifier: deadCode.unreachable
-			count: 2
-			path: ../../../src/wp-admin/includes/dashboard.php
 		-
 			message: '#^Unreachable statement \- code above always terminates\.$#'
 			identifier: deadCode.unreachable
 			count: 2
 			path: ../../../src/wp-admin/post.php
-		-
-			message: '#^Unreachable statement \- code above always terminates\.$#'
-			identifier: deadCode.unreachable
-			count: 1
-			path: ../../../src/wp-content/themes/twentyeleven/archive.php
-		-
-			message: '#^Unreachable statement \- code above always terminates\.$#'
-			identifier: deadCode.unreachable
-			count: 1
-			path: ../../../src/wp-content/themes/twentyeleven/author.php
-		-
-			message: '#^Unreachable statement \- code above always terminates\.$#'
-			identifier: deadCode.unreachable
-			count: 1
-			path: ../../../src/wp-content/themes/twentyeleven/category.php
-		-
-			message: '#^Unreachable statement \- code above always terminates\.$#'
-			identifier: deadCode.unreachable
-			count: 1
-			path: ../../../src/wp-content/themes/twentyeleven/inc/widgets.php
-		-
-			message: '#^Unreachable statement \- code above always terminates\.$#'
-			identifier: deadCode.unreachable
-			count: 1
-			path: ../../../src/wp-content/themes/twentyeleven/index.php
-		-
-			message: '#^Unreachable statement \- code above always terminates\.$#'
-			identifier: deadCode.unreachable
-			count: 1
-			path: ../../../src/wp-content/themes/twentyeleven/search.php
-		-
-			message: '#^Unreachable statement \- code above always terminates\.$#'
-			identifier: deadCode.unreachable
-			count: 1
-			path: ../../../src/wp-content/themes/twentyeleven/showcase.php
-		-
-			message: '#^Unreachable statement \- code above always terminates\.$#'
-			identifier: deadCode.unreachable
-			count: 1
-			path: ../../../src/wp-content/themes/twentyeleven/tag.php
-		-
-			message: '#^Unreachable statement \- code above always terminates\.$#'
-			identifier: deadCode.unreachable
-			count: 1
-			path: ../../../src/wp-content/themes/twentyfifteen/archive.php
-		-
-			message: '#^Unreachable statement \- code above always terminates\.$#'
-			identifier: deadCode.unreachable
-			count: 1
-			path: ../../../src/wp-content/themes/twentyfifteen/index.php
-		-
-			message: '#^Unreachable statement \- code above always terminates\.$#'
-			identifier: deadCode.unreachable
-			count: 1
-			path: ../../../src/wp-content/themes/twentyfifteen/search.php
-		-
-			message: '#^Unreachable statement \- code above always terminates\.$#'
-			identifier: deadCode.unreachable
-			count: 1
-			path: ../../../src/wp-content/themes/twentyfourteen/archive.php
-		-
-			message: '#^Unreachable statement \- code above always terminates\.$#'
-			identifier: deadCode.unreachable
-			count: 1
-			path: ../../../src/wp-content/themes/twentyfourteen/author.php
-		-
-			message: '#^Unreachable statement \- code above always terminates\.$#'
-			identifier: deadCode.unreachable
-			count: 1
-			path: ../../../src/wp-content/themes/twentyfourteen/category.php
-		-
-			message: '#^Unreachable statement \- code above always terminates\.$#'
-			identifier: deadCode.unreachable
-			count: 1
-			path: ../../../src/wp-content/themes/twentyfourteen/inc/widgets.php
-		-
-			message: '#^Unreachable statement \- code above always terminates\.$#'
-			identifier: deadCode.unreachable
-			count: 1
-			path: ../../../src/wp-content/themes/twentyfourteen/index.php
-		-
-			message: '#^Unreachable statement \- code above always terminates\.$#'
-			identifier: deadCode.unreachable
-			count: 1
-			path: ../../../src/wp-content/themes/twentyfourteen/search.php
-		-
-			message: '#^Unreachable statement \- code above always terminates\.$#'
-			identifier: deadCode.unreachable
-			count: 1
-			path: ../../../src/wp-content/themes/twentyfourteen/tag.php
-		-
-			message: '#^Unreachable statement \- code above always terminates\.$#'
-			identifier: deadCode.unreachable
-			count: 1
-			path: ../../../src/wp-content/themes/twentyfourteen/taxonomy-post_format.php
-		-
-			message: '#^Unreachable statement \- code above always terminates\.$#'
-			identifier: deadCode.unreachable
-			count: 1
-			path: ../../../src/wp-content/themes/twentynineteen/archive.php
-		-
-			message: '#^Unreachable statement \- code above always terminates\.$#'
-			identifier: deadCode.unreachable
-			count: 1
-			path: ../../../src/wp-content/themes/twentynineteen/index.php
-		-
-			message: '#^Unreachable statement \- code above always terminates\.$#'
-			identifier: deadCode.unreachable
-			count: 1
-			path: ../../../src/wp-content/themes/twentynineteen/search.php
-		-
-			message: '#^Unreachable statement \- code above always terminates\.$#'
-			identifier: deadCode.unreachable
-			count: 1
-			path: ../../../src/wp-content/themes/twentyseventeen/archive.php
-		-
-			message: '#^Unreachable statement \- code above always terminates\.$#'
-			identifier: deadCode.unreachable
-			count: 1
-			path: ../../../src/wp-content/themes/twentyseventeen/index.php
-		-
-			message: '#^Unreachable statement \- code above always terminates\.$#'
-			identifier: deadCode.unreachable
-			count: 1
-			path: ../../../src/wp-content/themes/twentyseventeen/search.php
-		-
-			message: '#^Unreachable statement \- code above always terminates\.$#'
-			identifier: deadCode.unreachable
-			count: 1
-			path: ../../../src/wp-content/themes/twentyseventeen/template-parts/page/content-front-page-panels.php
-		-
-			message: '#^Unreachable statement \- code above always terminates\.$#'
-			identifier: deadCode.unreachable
-			count: 1
-			path: ../../../src/wp-content/themes/twentysixteen/archive.php
-		-
-			message: '#^Unreachable statement \- code above always terminates\.$#'
-			identifier: deadCode.unreachable
-			count: 1
-			path: ../../../src/wp-content/themes/twentysixteen/index.php
-		-
-			message: '#^Unreachable statement \- code above always terminates\.$#'
-			identifier: deadCode.unreachable
-			count: 1
-			path: ../../../src/wp-content/themes/twentysixteen/search.php
-		-
-			message: '#^Unreachable statement \- code above always terminates\.$#'
-			identifier: deadCode.unreachable
-			count: 1
-			path: ../../../src/wp-content/themes/twentythirteen/archive.php
-		-
-			message: '#^Unreachable statement \- code above always terminates\.$#'
-			identifier: deadCode.unreachable
-			count: 1
-			path: ../../../src/wp-content/themes/twentythirteen/author.php
-		-
-			message: '#^Unreachable statement \- code above always terminates\.$#'
-			identifier: deadCode.unreachable
-			count: 1
-			path: ../../../src/wp-content/themes/twentythirteen/category.php
-		-
-			message: '#^Unreachable statement \- code above always terminates\.$#'
-			identifier: deadCode.unreachable
-			count: 1
-			path: ../../../src/wp-content/themes/twentythirteen/index.php
-		-
-			message: '#^Unreachable statement \- code above always terminates\.$#'
-			identifier: deadCode.unreachable
-			count: 1
-			path: ../../../src/wp-content/themes/twentythirteen/search.php
-		-
-			message: '#^Unreachable statement \- code above always terminates\.$#'
-			identifier: deadCode.unreachable
-			count: 1
-			path: ../../../src/wp-content/themes/twentythirteen/tag.php
-		-
-			message: '#^Unreachable statement \- code above always terminates\.$#'
-			identifier: deadCode.unreachable
-			count: 1
-			path: ../../../src/wp-content/themes/twentythirteen/taxonomy-post_format.php
-		-
-			message: '#^Unreachable statement \- code above always terminates\.$#'
-			identifier: deadCode.unreachable
-			count: 1
-			path: ../../../src/wp-content/themes/twentytwelve/archive.php
-		-
-			message: '#^Unreachable statement \- code above always terminates\.$#'
-			identifier: deadCode.unreachable
-			count: 1
-			path: ../../../src/wp-content/themes/twentytwelve/author.php
-		-
-			message: '#^Unreachable statement \- code above always terminates\.$#'
-			identifier: deadCode.unreachable
-			count: 1
-			path: ../../../src/wp-content/themes/twentytwelve/category.php
-		-
-			message: '#^Unreachable statement \- code above always terminates\.$#'
-			identifier: deadCode.unreachable
-			count: 1
-			path: ../../../src/wp-content/themes/twentytwelve/index.php
-		-
-			message: '#^Unreachable statement \- code above always terminates\.$#'
-			identifier: deadCode.unreachable
-			count: 1
-			path: ../../../src/wp-content/themes/twentytwelve/search.php
-		-
-			message: '#^Unreachable statement \- code above always terminates\.$#'
-			identifier: deadCode.unreachable
-			count: 1
-			path: ../../../src/wp-content/themes/twentytwelve/tag.php
-		-
-			message: '#^Unreachable statement \- code above always terminates\.$#'
-			identifier: deadCode.unreachable
-			count: 1
-			path: ../../../src/wp-content/themes/twentytwentyone/archive.php
-		-
-			message: '#^Unreachable statement \- code above always terminates\.$#'
-			identifier: deadCode.unreachable
-			count: 1
-			path: ../../../src/wp-content/themes/twentytwentyone/index.php
-		-
-			message: '#^Unreachable statement \- code above always terminates\.$#'
-			identifier: deadCode.unreachable
-			count: 1
-			path: ../../../src/wp-content/themes/twentytwentyone/search.php
 		-
 			message: '#^Unreachable statement \- code above always terminates\.$#'
 			identifier: deadCode.unreachable
diff --git a/tests/phpstan/baselines/if.alwaysTrue.neon b/tests/phpstan/baselines/if.alwaysTrue.neon
index f049efde2d19d..6888b9780b5f9 100644
--- a/tests/phpstan/baselines/if.alwaysTrue.neon
+++ b/tests/phpstan/baselines/if.alwaysTrue.neon
@@ -28,11 +28,6 @@ parameters:
 			identifier: if.alwaysTrue
 			count: 2
 			path: ../../../src/wp-admin/upload.php
-		-
-			message: '#^If condition is always true\.$#'
-			identifier: if.alwaysTrue
-			count: 1
-			path: ../../../src/wp-content/themes/twentynineteen/comments.php
 		-
 			message: '#^If condition is always true\.$#'
 			identifier: if.alwaysTrue
diff --git a/tests/phpstan/baselines/while.alwaysFalse.neon b/tests/phpstan/baselines/while.alwaysFalse.neon
deleted file mode 100644
index 3c924003ea783..0000000000000
--- a/tests/phpstan/baselines/while.alwaysFalse.neon
+++ /dev/null
@@ -1,25 +0,0 @@
-# PHPStan baseline for the `while.alwaysFalse` errors in WordPress core.
-#
-# https://phpstan.org/error-identifiers/while.alwaysFalse
-#
-# Each entry is scoped to a single file and carries an exact occurrence count,
-# so that a new instance is reported as a new error rather than being absorbed
-# silently. Fixing an occurrence therefore means decrementing or removing its
-# entry here as part of the same change.
-#
-# The goal is to empty this file and delete it, along with the `includes` entry
-# for it in phpstan.neon.dist.
-#
-# Generated by `composer phpstan:baselines`. Do not edit by hand; regenerate with
-#
-#     composer phpstan:baselines -- --identifier=while.alwaysFalse
-#
-# which reruns the analysis with this file suppressed so the errors surface again.
-
-parameters:
-	ignoreErrors:
-		-
-			message: '#^While loop condition is always false\.$#'
-			identifier: while.alwaysFalse
-			count: 1
-			path: ../../../src/wp-includes/feed-rdf.php
diff --git a/tests/phpstan/baselines/while.alwaysTrue.neon b/tests/phpstan/baselines/while.alwaysTrue.neon
deleted file mode 100644
index 5da6550e89cc0..0000000000000
--- a/tests/phpstan/baselines/while.alwaysTrue.neon
+++ /dev/null
@@ -1,300 +0,0 @@
-# PHPStan baseline for the `while.alwaysTrue` errors in WordPress core.
-#
-# https://phpstan.org/error-identifiers/while.alwaysTrue
-#
-# Each entry is scoped to a single file and carries an exact occurrence count,
-# so that a new instance is reported as a new error rather than being absorbed
-# silently. Fixing an occurrence therefore means decrementing or removing its
-# entry here as part of the same change.
-#
-# The goal is to empty this file and delete it, along with the `includes` entry
-# for it in phpstan.neon.dist.
-#
-# Generated by `composer phpstan:baselines`. Do not edit by hand; regenerate with
-#
-#     composer phpstan:baselines -- --identifier=while.alwaysTrue
-#
-# which reruns the analysis with this file suppressed so the errors surface again.
-
-parameters:
-	ignoreErrors:
-		-
-			message: '#^While loop condition is always true\.$#'
-			identifier: while.alwaysTrue
-			count: 1
-			path: ../../../src/wp-admin/includes/dashboard.php
-		-
-			message: '#^While loop condition is always true\.$#'
-			identifier: while.alwaysTrue
-			count: 1
-			path: ../../../src/wp-admin/includes/nav-menu.php
-		-
-			message: '#^While loop condition is always true\.$#'
-			identifier: while.alwaysTrue
-			count: 1
-			path: ../../../src/wp-content/themes/twentyeleven/archive.php
-		-
-			message: '#^While loop condition is always true\.$#'
-			identifier: while.alwaysTrue
-			count: 1
-			path: ../../../src/wp-content/themes/twentyeleven/author.php
-		-
-			message: '#^While loop condition is always true\.$#'
-			identifier: while.alwaysTrue
-			count: 1
-			path: ../../../src/wp-content/themes/twentyeleven/category.php
-		-
-			message: '#^While loop condition is always true\.$#'
-			identifier: while.alwaysTrue
-			count: 1
-			path: ../../../src/wp-content/themes/twentyeleven/inc/widgets.php
-		-
-			message: '#^While loop condition is always true\.$#'
-			identifier: while.alwaysTrue
-			count: 1
-			path: ../../../src/wp-content/themes/twentyeleven/index.php
-		-
-			message: '#^While loop condition is always true\.$#'
-			identifier: while.alwaysTrue
-			count: 1
-			path: ../../../src/wp-content/themes/twentyeleven/search.php
-		-
-			message: '#^While loop condition is always true\.$#'
-			identifier: while.alwaysTrue
-			count: 1
-			path: ../../../src/wp-content/themes/twentyeleven/showcase.php
-		-
-			message: '#^While loop condition is always true\.$#'
-			identifier: while.alwaysTrue
-			count: 1
-			path: ../../../src/wp-content/themes/twentyeleven/tag.php
-		-
-			message: '#^While loop condition is always true\.$#'
-			identifier: while.alwaysTrue
-			count: 1
-			path: ../../../src/wp-content/themes/twentyfifteen/archive.php
-		-
-			message: '#^While loop condition is always true\.$#'
-			identifier: while.alwaysTrue
-			count: 1
-			path: ../../../src/wp-content/themes/twentyfifteen/index.php
-		-
-			message: '#^While loop condition is always true\.$#'
-			identifier: while.alwaysTrue
-			count: 1
-			path: ../../../src/wp-content/themes/twentyfifteen/search.php
-		-
-			message: '#^While loop condition is always true\.$#'
-			identifier: while.alwaysTrue
-			count: 1
-			path: ../../../src/wp-content/themes/twentyfourteen/archive.php
-		-
-			message: '#^While loop condition is always true\.$#'
-			identifier: while.alwaysTrue
-			count: 1
-			path: ../../../src/wp-content/themes/twentyfourteen/author.php
-		-
-			message: '#^While loop condition is always true\.$#'
-			identifier: while.alwaysTrue
-			count: 1
-			path: ../../../src/wp-content/themes/twentyfourteen/category.php
-		-
-			message: '#^While loop condition is always true\.$#'
-			identifier: while.alwaysTrue
-			count: 1
-			path: ../../../src/wp-content/themes/twentyfourteen/inc/widgets.php
-		-
-			message: '#^While loop condition is always true\.$#'
-			identifier: while.alwaysTrue
-			count: 1
-			path: ../../../src/wp-content/themes/twentyfourteen/index.php
-		-
-			message: '#^While loop condition is always true\.$#'
-			identifier: while.alwaysTrue
-			count: 1
-			path: ../../../src/wp-content/themes/twentyfourteen/search.php
-		-
-			message: '#^While loop condition is always true\.$#'
-			identifier: while.alwaysTrue
-			count: 1
-			path: ../../../src/wp-content/themes/twentyfourteen/tag.php
-		-
-			message: '#^While loop condition is always true\.$#'
-			identifier: while.alwaysTrue
-			count: 1
-			path: ../../../src/wp-content/themes/twentyfourteen/taxonomy-post_format.php
-		-
-			message: '#^While loop condition is always true\.$#'
-			identifier: while.alwaysTrue
-			count: 1
-			path: ../../../src/wp-content/themes/twentynineteen/archive.php
-		-
-			message: '#^While loop condition is always true\.$#'
-			identifier: while.alwaysTrue
-			count: 1
-			path: ../../../src/wp-content/themes/twentynineteen/index.php
-		-
-			message: '#^While loop condition is always true\.$#'
-			identifier: while.alwaysTrue
-			count: 1
-			path: ../../../src/wp-content/themes/twentynineteen/search.php
-		-
-			message: '#^While loop condition is always true\.$#'
-			identifier: while.alwaysTrue
-			count: 1
-			path: ../../../src/wp-content/themes/twentyseventeen/archive.php
-		-
-			message: '#^While loop condition is always true\.$#'
-			identifier: while.alwaysTrue
-			count: 1
-			path: ../../../src/wp-content/themes/twentyseventeen/front-page.php
-		-
-			message: '#^While loop condition is always true\.$#'
-			identifier: while.alwaysTrue
-			count: 1
-			path: ../../../src/wp-content/themes/twentyseventeen/index.php
-		-
-			message: '#^While loop condition is always true\.$#'
-			identifier: while.alwaysTrue
-			count: 1
-			path: ../../../src/wp-content/themes/twentyseventeen/search.php
-		-
-			message: '#^While loop condition is always true\.$#'
-			identifier: while.alwaysTrue
-			count: 1
-			path: ../../../src/wp-content/themes/twentyseventeen/template-parts/page/content-front-page-panels.php
-		-
-			message: '#^While loop condition is always true\.$#'
-			identifier: while.alwaysTrue
-			count: 1
-			path: ../../../src/wp-content/themes/twentysixteen/archive.php
-		-
-			message: '#^While loop condition is always true\.$#'
-			identifier: while.alwaysTrue
-			count: 1
-			path: ../../../src/wp-content/themes/twentysixteen/index.php
-		-
-			message: '#^While loop condition is always true\.$#'
-			identifier: while.alwaysTrue
-			count: 1
-			path: ../../../src/wp-content/themes/twentysixteen/search.php
-		-
-			message: '#^While loop condition is always true\.$#'
-			identifier: while.alwaysTrue
-			count: 1
-			path: ../../../src/wp-content/themes/twentyten/loop-attachment.php
-		-
-			message: '#^While loop condition is always true\.$#'
-			identifier: while.alwaysTrue
-			count: 1
-			path: ../../../src/wp-content/themes/twentyten/loop-page.php
-		-
-			message: '#^While loop condition is always true\.$#'
-			identifier: while.alwaysTrue
-			count: 1
-			path: ../../../src/wp-content/themes/twentyten/loop-single.php
-		-
-			message: '#^While loop condition is always true\.$#'
-			identifier: while.alwaysTrue
-			count: 1
-			path: ../../../src/wp-content/themes/twentythirteen/archive.php
-		-
-			message: '#^While loop condition is always true\.$#'
-			identifier: while.alwaysTrue
-			count: 1
-			path: ../../../src/wp-content/themes/twentythirteen/author.php
-		-
-			message: '#^While loop condition is always true\.$#'
-			identifier: while.alwaysTrue
-			count: 1
-			path: ../../../src/wp-content/themes/twentythirteen/category.php
-		-
-			message: '#^While loop condition is always true\.$#'
-			identifier: while.alwaysTrue
-			count: 1
-			path: ../../../src/wp-content/themes/twentythirteen/index.php
-		-
-			message: '#^While loop condition is always true\.$#'
-			identifier: while.alwaysTrue
-			count: 1
-			path: ../../../src/wp-content/themes/twentythirteen/search.php
-		-
-			message: '#^While loop condition is always true\.$#'
-			identifier: while.alwaysTrue
-			count: 1
-			path: ../../../src/wp-content/themes/twentythirteen/tag.php
-		-
-			message: '#^While loop condition is always true\.$#'
-			identifier: while.alwaysTrue
-			count: 1
-			path: ../../../src/wp-content/themes/twentythirteen/taxonomy-post_format.php
-		-
-			message: '#^While loop condition is always true\.$#'
-			identifier: while.alwaysTrue
-			count: 1
-			path: ../../../src/wp-content/themes/twentytwelve/archive.php
-		-
-			message: '#^While loop condition is always true\.$#'
-			identifier: while.alwaysTrue
-			count: 1
-			path: ../../../src/wp-content/themes/twentytwelve/author.php
-		-
-			message: '#^While loop condition is always true\.$#'
-			identifier: while.alwaysTrue
-			count: 1
-			path: ../../../src/wp-content/themes/twentytwelve/category.php
-		-
-			message: '#^While loop condition is always true\.$#'
-			identifier: while.alwaysTrue
-			count: 1
-			path: ../../../src/wp-content/themes/twentytwelve/index.php
-		-
-			message: '#^While loop condition is always true\.$#'
-			identifier: while.alwaysTrue
-			count: 1
-			path: ../../../src/wp-content/themes/twentytwelve/search.php
-		-
-			message: '#^While loop condition is always true\.$#'
-			identifier: while.alwaysTrue
-			count: 1
-			path: ../../../src/wp-content/themes/twentytwelve/tag.php
-		-
-			message: '#^While loop condition is always true\.$#'
-			identifier: while.alwaysTrue
-			count: 1
-			path: ../../../src/wp-content/themes/twentytwenty/index.php
-		-
-			message: '#^While loop condition is always true\.$#'
-			identifier: while.alwaysTrue
-			count: 1
-			path: ../../../src/wp-content/themes/twentytwenty/singular.php
-		-
-			message: '#^While loop condition is always true\.$#'
-			identifier: while.alwaysTrue
-			count: 1
-			path: ../../../src/wp-content/themes/twentytwenty/templates/template-cover.php
-		-
-			message: '#^While loop condition is always true\.$#'
-			identifier: while.alwaysTrue
-			count: 1
-			path: ../../../src/wp-content/themes/twentytwentyone/archive.php
-		-
-			message: '#^While loop condition is always true\.$#'
-			identifier: while.alwaysTrue
-			count: 1
-			path: ../../../src/wp-content/themes/twentytwentyone/index.php
-		-
-			message: '#^While loop condition is always true\.$#'
-			identifier: while.alwaysTrue
-			count: 1
-			path: ../../../src/wp-content/themes/twentytwentyone/search.php
-		-
-			message: '#^While loop condition is always true\.$#'
-			identifier: while.alwaysTrue
-			count: 1
-			path: ../../../src/wp-includes/block-template.php
-		-
-			message: '#^While loop condition is always true\.$#'
-			identifier: while.alwaysTrue
-			count: 1
-			path: ../../../src/wp-includes/theme-compat/embed.php

From 986fda1417f5eee38d8145319cb11a7791541363 Mon Sep 17 00:00:00 2001
From: Dimitrios Pantazis <dpanta94@gmail.com>
Date: Sun, 16 Aug 2026 11:04:35 -0700
Subject: [PATCH 2/2] tests: coverage for GLOBALS['more'] restoration after
 while loop

---
 .../theme/twentyFourteenEphemeraWidget.php    | 50 +++++++++++++++++++
 1 file changed, 50 insertions(+)
 create mode 100644 tests/phpunit/tests/theme/twentyFourteenEphemeraWidget.php

diff --git a/tests/phpunit/tests/theme/twentyFourteenEphemeraWidget.php b/tests/phpunit/tests/theme/twentyFourteenEphemeraWidget.php
new file mode 100644
index 0000000000000..fc0622df3682c
--- /dev/null
+++ b/tests/phpunit/tests/theme/twentyFourteenEphemeraWidget.php
@@ -0,0 +1,50 @@
+<?php
+
+/**
+ * @group themes
+ * @group widgets
+ *
+ * @covers Twenty_Fourteen_Ephemera_Widget::widget
+ */
+class Tests_Theme_TwentyFourteenEphemeraWidget extends WP_UnitTestCase {
+
+	public function set_up() {
+		parent::set_up();
+
+		$widgets = WP_CONTENT_DIR . '/themes/twentyfourteen/inc/widgets.php';
+		if ( ! file_exists( $widgets ) ) {
+			$this->markTestSkipped( 'The Twenty Fourteen theme is not installed.' );
+		}
+		require_once $widgets;
+	}
+
+	/**
+	 * The widget must restore the original `$more` global, not the zeroed value
+	 * it sets for each post it renders.
+	 */
+	public function test_widget_restores_more_global() {
+		// More than one post, so a stale `$more` from a previous iteration would be restored.
+		foreach ( self::factory()->post->create_many( 2 ) as $post_id ) {
+			set_post_format( $post_id, 'aside' );
+		}
+
+		$GLOBALS['more']          = 1;
+		$GLOBALS['content_width'] = 474;
+
+		$widget = new Twenty_Fourteen_Ephemera_Widget();
+
+		ob_start();
+		$widget->widget(
+			array(
+				'before_widget' => '',
+				'after_widget'  => '',
+			),
+			array( 'format' => 'aside' )
+		);
+		$output = ob_get_clean();
+
+		$this->assertNotEmpty( $output, 'The widget rendered nothing, so nothing was restored.' );
+		$this->assertSame( 1, $GLOBALS['more'], 'The $more global was not restored to its original value.' );
+		$this->assertSame( 474, $GLOBALS['content_width'], 'The $content_width global was not restored to its original value.' );
+	}
+}