From 5dd289dc9aaeca2333d0b0d556e7405f675b01af Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A9=20Schild?= <a.schild@aarboard.ch>
Date: Fri, 24 Jul 2026 11:36:03 +0200
Subject: [PATCH] test: disable password_policy in the test container so
 user-creation tests pass

On a fresh Nextcloud the default password_policy app rejects the fixed
simple passwords used by the tests, so createUser returned false and every
user-dependent test (and the sharing tests, whose setUp creates a user)
cascaded into failure. Disable the app after the container starts via occ
(run as www-data) so the test environment is deterministic.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
---
 .../nextcloud/api/NextcloudTestContainer.java | 29 +++++++++++++++++++
 1 file changed, 29 insertions(+)

diff --git a/src/test/java/org/aarboard/nextcloud/api/NextcloudTestContainer.java b/src/test/java/org/aarboard/nextcloud/api/NextcloudTestContainer.java
index 4efeba6..d0b8816 100644
--- a/src/test/java/org/aarboard/nextcloud/api/NextcloudTestContainer.java
+++ b/src/test/java/org/aarboard/nextcloud/api/NextcloudTestContainer.java
@@ -16,9 +16,12 @@
  */
 package org.aarboard.nextcloud.api;
 
+import java.io.IOException;
 import java.time.Duration;
 
 import org.testcontainers.DockerClientFactory;
+import org.testcontainers.containers.Container.ExecResult;
+import org.testcontainers.containers.ExecConfig;
 import org.testcontainers.containers.GenericContainer;
 import org.testcontainers.containers.wait.strategy.Wait;
 import org.testcontainers.utility.DockerImageName;
@@ -107,10 +110,36 @@ public static synchronized void ensureStarted() {
                         .forResponsePredicate(body -> body.contains("\"installed\":true"))
                         .withStartupTimeout(Duration.ofMinutes(5)));
         container.start();
+        disablePasswordPolicy();
 
         System.setProperty("nextcloud.api.test.servername", container.getHost());
         System.setProperty("nextcloud.api.test.serverport", String.valueOf(container.getMappedPort(80)));
         System.setProperty("nextcloud.api.test.username", ADMIN_USER);
         System.setProperty("nextcloud.api.test.password", ADMIN_PASSWORD);
     }
+
+    /**
+     * Disables the {@code password_policy} app so the tests, which create users
+     * with fixed simple passwords, are not rejected by Nextcloud's default
+     * password/complexity/breach checks. Best-effort: a failure here is logged
+     * but does not abort the suite. occ must run as the {@code www-data} user
+     * (it refuses to run as root).
+     */
+    private static void disablePasswordPolicy() {
+        try {
+            ExecResult result = container.execInContainer(ExecConfig.builder()
+                    .user("www-data")
+                    .command(new String[] {"php", "occ", "app:disable", "password_policy"})
+                    .build());
+            if (result.getExitCode() != 0) {
+                System.err.println("Could not disable password_policy app: "
+                        + result.getStdout() + result.getStderr());
+            }
+        } catch (IOException | InterruptedException e) {
+            System.err.println("Could not disable password_policy app: " + e.getMessage());
+            if (e instanceof InterruptedException) {
+                Thread.currentThread().interrupt();
+            }
+        }
+    }
 }