From aace3f7403d718e7ec26676ce0753a931133d753 Mon Sep 17 00:00:00 2001 From: cditcher Date: Fri, 19 Jun 2026 10:00:58 -0700 Subject: [PATCH 1/2] Test --- .../educ/api/ruleengine/rule/RegistrationsFailedCrseRule.java | 1 + 1 file changed, 1 insertion(+) diff --git a/api/src/main/java/ca/bc/gov/educ/api/ruleengine/rule/RegistrationsFailedCrseRule.java b/api/src/main/java/ca/bc/gov/educ/api/ruleengine/rule/RegistrationsFailedCrseRule.java index a67673a..f6e5a86 100644 --- a/api/src/main/java/ca/bc/gov/educ/api/ruleengine/rule/RegistrationsFailedCrseRule.java +++ b/api/src/main/java/ca/bc/gov/educ/api/ruleengine/rule/RegistrationsFailedCrseRule.java @@ -34,6 +34,7 @@ public class RegistrationsFailedCrseRule extends BaseRule implements Rule { public RuleData fire() { List studentCourseList = ruleProcessorData.getStudentCourses(); Calendar cal = Calendar.getInstance(TimeZone.getTimeZone("PST"), Locale.CANADA); + // test comment boolean inProgressCourse = false; for (StudentCourse studentCourse : studentCourseList) { if (RuleEngineApiUtils.isCompletedCourse(studentCourse.getCompletedCourseLetterGrade(), studentCourse.getCompletedCoursePercentage())) { From 87a619083885fe747a43064cb3bdece1efd612c6 Mon Sep 17 00:00:00 2001 From: Chris Ditcher Date: Fri, 19 Jun 2026 10:13:37 -0700 Subject: [PATCH 2/2] Update on.pr.yml (cherry picked from commit 136e627130d63f8e0a22e5e217d534a7c42d7bae) --- .github/workflows/on.pr.yml | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/.github/workflows/on.pr.yml b/.github/workflows/on.pr.yml index 4ac8219..c0c7ee9 100644 --- a/.github/workflows/on.pr.yml +++ b/.github/workflows/on.pr.yml @@ -38,9 +38,16 @@ jobs: with: path: ~/.sonar/cache key: ${{ runner.os }}-sonar + - name: Check Sonar inputs + shell: bash + run: | + [ -n "${{ secrets.SONAR_TOKEN }}" ] && echo "SONAR_TOKEN present" || echo "SONAR_TOKEN missing" + [ -n "${{ vars.SONAR_HOST_URL }}" ] && echo "SONAR_HOST_URL present" || echo "SONAR_HOST_URL missing" + [ -n "${{ vars.SONAR_ORG }}" ] && echo "SONAR_ORG present" || echo "SONAR_ORG missing" + [ -n "${{ vars.SONAR_PROJECT_KEY }}" ] && echo "SONAR_PROJECT_KEY present" || echo "SONAR_PROJECT_KEY missing" - name: Run Sonar Analysis run: mvn sonar:sonar - -Dsonar.login=${{ secrets.SONAR_TOKEN }} + -Dsonar.token=${{ secrets.SONAR_TOKEN }} -Dsonar.host.url=${{ vars.SONAR_HOST_URL }} -Dsonar.organization=${{ vars.SONAR_ORG }} -Dsonar.projectKey=${{ vars.SONAR_PROJECT_KEY }}