From 1d5868e5d8721e88a5456396d068d219971d30e8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kr=C3=A6n=20Hansen?= Date: Mon, 10 Aug 2026 21:28:13 +0200 Subject: [PATCH 1/2] ci: stop piping the macOS xcodebuild through xcbeautify xcbeautify prints the failure summary of a failed archive but not the output of the script phase that actually failed, and its stdout is block-buffered through the pipe, so the tail of the build never reaches the job log either. A failing archive left nothing to diagnose. Take the raw xcodebuild output instead: verbose, but complete and correctly ordered. It was the only use of xcbeautify in the repo. Co-Authored-By: Claude Opus 5 (1M context) --- .github/workflows/check.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/check.yml b/.github/workflows/check.yml index c376521b..559b5f28 100644 --- a/.github/workflows/check.yml +++ b/.github/workflows/check.yml @@ -222,8 +222,7 @@ jobs: run: npx react-native bundle --entry-file index.js --platform macos --dev false --minify false --bundle-output dist/main.macos.jsbundle --assets-dest dist/res working-directory: apps/macos-test-app - name: Build test app - # pipefail so an xcodebuild failure is not masked by xcbeautify's exit code - run: set -o pipefail && xcodebuild archive -workspace MacOSTestApp.xcworkspace -configuration Release -scheme MacOSTestApp-macOS -destination generic/platform="macOS" -archivePath ./build/macos-test-app.xcarchive | xcbeautify + run: xcodebuild archive -workspace MacOSTestApp.xcworkspace -configuration Release -scheme MacOSTestApp-macOS -destination generic/platform="macOS" -archivePath ./build/macos-test-app.xcarchive working-directory: apps/macos-test-app/macos - name: Run test app run: npx mocha-remote --exit-on-error -- macos/build/macos-test-app.xcarchive/Products/Applications/MacOSTestApp.app/Contents/MacOS/MacOSTestApp From 6495d95e5f06d82efbaf2a44d325cb63aeade9ef Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kr=C3=A6n=20Hansen?= Date: Mon, 10 Aug 2026 21:31:45 +0200 Subject: [PATCH 2/2] ci: note the macOS job's tracking issue on its label gate Keeps the existing rationale for the gate and adds the issue tracking the react-native-macos version block that keeps it in place for now. Co-Authored-By: Claude Opus 5 (1M context) --- .github/workflows/check.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/check.yml b/.github/workflows/check.yml index 559b5f28..533bdece 100644 --- a/.github/workflows/check.yml +++ b/.github/workflows/check.yml @@ -185,7 +185,8 @@ jobs: working-directory: apps/test-app test-macos: # Disabling this on main for now, as initializing the template takes a long time and - # we don't have macOS-specific code yet + # we don't have macOS-specific code yet. Currently also blocked on react-native-macos: + # https://github.com/callstackincubator/react-native-node-api/issues/392 if: contains(github.event.pull_request.labels.*.name, 'MacOS 💻') name: Test app (macOS) runs-on: macos-latest