From 39da69262e0dd45c355a2c36b0bb9227bb471f1c Mon Sep 17 00:00:00 2001 From: Morgan Roderick Date: Tue, 30 Jun 2026 10:18:36 +0200 Subject: [PATCH] fix: remove broken organisers eager load on Event and Meeting queries MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit includes(:organisers) on Event and Meeting generates broken SQL — Rails' preloader applies the scope condition WHERE permissions.name = 'organiser' without joining the permissions table, causing PG::UndefinedTable on production data. Workshop includes(:organisers) works because its complex associations (sponsors, host) force Rails to use eager_load (LEFT JOINs), which correctly includes the permissions table. The original Bullet report only flagged Workshop#organisers and Event#organisers — Meeting was never reported. The Event fix worked in development (light data) but fails on production data. --- app/controllers/events_controller.rb | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/app/controllers/events_controller.rb b/app/controllers/events_controller.rb index 2c3f3e61c..25874beba 100644 --- a/app/controllers/events_controller.rb +++ b/app/controllers/events_controller.rb @@ -78,8 +78,8 @@ def fetch_upcoming_events .joins(:chapter) .merge(Chapter.active) ] - events << Meeting.upcoming.includes(:venue, :organisers).all - events << Event.upcoming.includes(:venue, :sponsors, :sponsorships, :permissions, :organisers).all + events << Meeting.upcoming.includes(:venue).all + events << Event.upcoming.includes(:venue, :sponsors, :sponsorships, :permissions).all sorted = events.compact.flatten.sort_by(&:date_and_time) return [{}, nil] if sorted.empty? @@ -100,8 +100,8 @@ def fetch_past_events .joins(:chapter) .merge(Chapter.active) ] - events << Meeting.past.includes(:venue, :organisers).all - events << Event.past.includes(:venue, :sponsors, :sponsorships, :permissions, :organisers).all + events << Meeting.past.includes(:venue).all + events << Event.past.includes(:venue, :sponsors, :sponsorships, :permissions).all sorted = events.compact.flatten.sort_by(&:date_and_time).reverse return [{}, nil] if sorted.empty?