fix(client): make DevframeRpcClient.close() optional

Copilot's review on this PR flagged both close() additions
(DevframeRpcClient and DevframeRpcClientMode) as a breaking change:
adding a required property to an exported, externally-implementable
interface breaks any existing consumer that hand-types a mock/adapter
against it without close() — as this repo's own rpc-auth-gate.test.ts
mock did until now.

Made close?: () => void on both interfaces instead. Every factory this
repo owns (createWsRpcClientMode, createStaticRpcClientMode) still
provides it unconditionally, so nothing here loses close(); only the
type requirement is relaxed. getDevframeRpcClient's close now calls
mode.close?.() to match.

Updated the three call sites that invoked close() directly against the
now-optional type (rpc.test.ts, rpc-ws-status.test.ts) to close?.(), and
removed the auth-gate mock's close() entirely rather than keep it,
since a mode without one is now exactly the scenario this is meant to
keep working — a new test asserts rpc.close() against it doesn't throw.

Verified with a full `pnpm run build` + `pnpm exec vitest run --project
tests -u`: only the client tsnapi snapshot changed (close: () => void
-> close?: () => void), nothing else. Full suite: 101 files, 1088 tests
(was 1087), all green. `pnpm run typecheck` and `pnpm run lint` clean
across all 22 packages.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Author: dvcolomban

packages/devframe/src/client/rpc-auth-gate.test.ts

@@ -37,7 +37,8 @@ vi.mock('./rpc-ws', () => ({
     call: fakeMode.call as DevframeRpcClientMode['call'],
     callOptional: fakeMode.callOptional as DevframeRpcClientMode['callOptional'],
     callEvent: fakeMode.callEvent as DevframeRpcClientMode['callEvent'],
-    close: () => {},
+    // No `close` here on purpose — `close` is optional precisely so a mode written before it
+    // existed (this one) still satisfies the interface.
   })),
 }))
 
@@ -138,4 +139,17 @@ describe('getDevframeRpcClient — auth bootstrap gates outbound calls', () => {
     // Sent straight through — no more waiting once bootstrap is over.
     expect(fakeMode.call).toHaveBeenCalledTimes(1)
   })
+
+  it('close() is a no-op, not a throw, against a mode that predates it', async () => {
+    const { getDevframeRpcClient } = await import('./rpc')
+    const rpc = await getDevframeRpcClient({
+      connectionMeta,
+      otpParam: false,
+      simpleAuth: false,
+    })
+
+    // The mocked mode above has no `close` at all — exactly the pre-existing-mode case
+    // `close?:` exists to keep working.
+    expect(() => rpc.close?.()).not.toThrow()
+  })
 })

packages/devframe/src/client/rpc-ws-status.test.ts

@@ -153,7 +153,7 @@ describe('ws client connection status', () => {
     const { mode, ws } = setup()
     const closeSpy = vi.spyOn(ws, 'close')
 
-    mode.close()
+    mode.close?.()
 
     expect(closeSpy).toHaveBeenCalledTimes(1)
   })

packages/devframe/src/client/rpc.test.ts

@@ -172,7 +172,7 @@ describe('getDevframeRpcClient — connection meta base', () => {
     const ws = FakeWebSocket.instances.at(-1)!
     const closeSpy = vi.spyOn(ws, 'close')
 
-    rpc.close()
+    rpc.close?.()
 
     expect(closeSpy).toHaveBeenCalledTimes(1)
   })
@@ -190,7 +190,7 @@ describe('getDevframeRpcClient — connection meta base', () => {
 
     const rpc = await getDevframeRpcClient({ baseURL: '/__foo/', otpParam: false })
 
-    expect(() => rpc.close()).not.toThrow()
+    expect(() => rpc.close?.()).not.toThrow()
     // Static backends never open a socket in the first place.
     expect(FakeWebSocket.instances).toHaveLength(0)
   })

packages/devframe/src/client/rpc.ts

@@ -203,8 +203,12 @@ export interface DevframeRpcClient {
    *
    * There is no corresponding "reconnect" — a closed client is done. Discard it and call
    * {@link getDevframeRpcClient} again to reconnect.
+   *
+   * Optional so a `DevframeRpcClientMode` implemented before this method existed — a custom
+   * transport, a hand-typed mock — still satisfies the interface; an absent `close` is treated
+   * as nothing to close.
    */
-  close: () => void
+  close?: () => void
 }
 
 export interface DevframeRpcClientMode {
@@ -223,7 +227,7 @@ export interface DevframeRpcClientMode {
   callEvent: DevframeRpcClient['callEvent']
   callOptional: DevframeRpcClient['callOptional']
   /** See {@link DevframeRpcClient.close}. */
-  close: () => void
+  close?: () => void
 }
 
 export async function getDevframeRpcClient(
@@ -387,7 +391,7 @@ export async function getDevframeRpcClient(
     streaming: undefined!,
     cacheManager,
     scope: undefined!,
-    close: () => mode.close(),
+    close: () => mode.close?.(),
   }
 
   rpc.sharedState = createRpcSharedStateClientHost(rpc)

tests/__snapshots__/tsnapi/devframe/client.snapshot.d.ts

@@ -29,7 +29,7 @@ export interface DevframeRpcClient {
     <NS extends string>(_: NS): DevframeScopedClientContext<NS, SettingsForNamespace<NS>>;
     (_?: null | ''): DevframeRpcClient;
   };
-  close: () => void;
+  close?: () => void;
 }
 export interface DevframeRpcClientMode {
   readonly isTrusted: boolean;
@@ -42,7 +42,7 @@ export interface DevframeRpcClientMode {
   call: DevframeRpcClient['call'];
   callEvent: DevframeRpcClient['callEvent'];
   callOptional: DevframeRpcClient['callOptional'];
-  close: () => void;
+  close?: () => void;
 }
 export interface DevframeRpcClientOptions extends SetupDevframeConnectionOptions {
   authToken?: string;