Ruby: wip fixes

Author: aschackmull

ruby/ql/lib/codeql/ruby/ast/internal/Synthesis.qll

@@ -833,6 +833,10 @@ private module AssignOperationDesugar {
         )
       )
     }
+
+    final override predicate excludeFromControlFlowTree(AstNode n) {
+      n = any(ScopeResolutionAssignOperation sao).getLeftOperand()
+    }
   }
 
   /** An assignment operation where the left-hand side is a method call. */

ruby/ql/lib/codeql/ruby/controlflow/ControlFlowGraph2.qll

@@ -89,6 +89,29 @@ private module Ast implements AstSig<Location> {
       index = 1 and pair.getValue() = result
     )
     or
+    exists(R::Ast::ArrayPattern arraypattern | parent = arraypattern |
+      index = -1 and arraypattern.getClass() = result
+      or
+      arraypattern.getPrefixElement(index) = result
+      or
+      exists(int restix | restix = count(arraypattern.getPrefixElement(_)) |
+        restix = index and arraypattern.getRestVariableAccess() = result
+        or
+        arraypattern.getSuffixElement(index - restix - 1) = result
+      )
+    )
+    or
+    exists(R::Ast::FindPattern findpattern | parent = findpattern |
+      index = -2 and findpattern.getClass() = result
+      or
+      index = -1 and findpattern.getPrefixVariableAccess() = result
+      or
+      findpattern.getElement(index) = result
+      or
+      index = 1 + max(int i | exists(findpattern.getElement(i))) and
+      findpattern.getSuffixVariableAccess() = result
+    )
+    or
     exists(R::Ast::HashPattern hashpattern | parent = hashpattern |
       index = -1 and hashpattern.getClass() = result
       or