diff --git a/src/specify_cli/workflows/catalog.py b/src/specify_cli/workflows/catalog.py index 61f490631c..028fce74d0 100644 --- a/src/specify_cli/workflows/catalog.py +++ b/src/specify_cli/workflows/catalog.py @@ -784,12 +784,14 @@ def remove_catalog(self, index: int) -> str: raise WorkflowValidationError("No catalog config file found.") try: - data = yaml.safe_load(config_path.read_text(encoding="utf-8")) or {} + data = yaml.safe_load(config_path.read_text(encoding="utf-8")) except (yaml.YAMLError, OSError, UnicodeDecodeError) as exc: raise WorkflowValidationError( f"Catalog config file is unreadable or malformed: {exc}" ) from exc - if not isinstance(data, dict): + if data is None: + data = {} + elif not isinstance(data, dict): raise WorkflowValidationError( "Catalog config file is corrupted (expected a mapping)." ) diff --git a/tests/test_workflows.py b/tests/test_workflows.py index 95baf22d3c..0243e0c185 100644 --- a/tests/test_workflows.py +++ b/tests/test_workflows.py @@ -8148,6 +8148,18 @@ def test_remove_catalog_invalid_index(self, project_dir): with pytest.raises(WorkflowValidationError, match="out of range"): catalog.remove_catalog(5) + @pytest.mark.parametrize("bad", [[], False, 0, ""]) + def test_remove_catalog_rejects_falsy_non_mapping_config( + self, project_dir, bad + ): + from specify_cli.workflows.catalog import WorkflowCatalog, WorkflowValidationError + + config_path = project_dir / ".specify" / "workflow-catalogs.yml" + config_path.write_text(yaml.safe_dump(bad), encoding="utf-8") + + with pytest.raises(WorkflowValidationError, match="expected a mapping"): + WorkflowCatalog(project_dir).remove_catalog(0) + def test_get_catalog_configs(self, project_dir): from specify_cli.workflows.catalog import WorkflowCatalog