From 62eeb63761206a448705705e5765044a517e3170 Mon Sep 17 00:00:00 2001 From: tabgab Date: Mon, 6 Jul 2026 13:18:13 +0300 Subject: [PATCH] visualizer/osg: include where cenvir.h's fwd-decl was relied on omnetpp topic/VSG commit fc5a453385 ("remove the dead refOsgNode/unrefOsgNode ref-counting chain") dropped the "namespace osg { class Node; }" forward declaration from cenvir.h together with the two cEnvir pure virtuals. Three OSG visualizer headers use osg::Node while including only , so they picked up the declaration transitively from and no longer compile. Include explicitly, as the sibling OSG visualizer headers already do. Note: removing the two pure virtuals also changed the cEnvir vtable layout, so any libINET built against the older headers crashes at load time (SIGBUS in SharedDataManager::getInstance() at the first virtual call through cEnvir). A full rebuild against the new headers is required either way; this commit is what makes that rebuild succeed. Co-Authored-By: Claude Fable 5 --- src/inet/visualizer/osg/common/PacketDropOsgVisualizer.h | 1 + src/inet/visualizer/osg/linklayer/LinkBreakOsgVisualizer.h | 1 + src/inet/visualizer/osg/networklayer/RoutingTableOsgVisualizer.h | 1 + 3 files changed, 3 insertions(+) diff --git a/src/inet/visualizer/osg/common/PacketDropOsgVisualizer.h b/src/inet/visualizer/osg/common/PacketDropOsgVisualizer.h index 1026ba97ebc..d6f99b8203b 100644 --- a/src/inet/visualizer/osg/common/PacketDropOsgVisualizer.h +++ b/src/inet/visualizer/osg/common/PacketDropOsgVisualizer.h @@ -8,6 +8,7 @@ #ifndef __INET_PACKETDROPOSGVISUALIZER_H #define __INET_PACKETDROPOSGVISUALIZER_H +#include #include #include "inet/visualizer/base/PacketDropVisualizerBase.h" diff --git a/src/inet/visualizer/osg/linklayer/LinkBreakOsgVisualizer.h b/src/inet/visualizer/osg/linklayer/LinkBreakOsgVisualizer.h index 4c08d14e018..1b14e48b264 100644 --- a/src/inet/visualizer/osg/linklayer/LinkBreakOsgVisualizer.h +++ b/src/inet/visualizer/osg/linklayer/LinkBreakOsgVisualizer.h @@ -8,6 +8,7 @@ #ifndef __INET_LINKBREAKOSGVISUALIZER_H #define __INET_LINKBREAKOSGVISUALIZER_H +#include #include #include "inet/visualizer/base/LinkBreakVisualizerBase.h" diff --git a/src/inet/visualizer/osg/networklayer/RoutingTableOsgVisualizer.h b/src/inet/visualizer/osg/networklayer/RoutingTableOsgVisualizer.h index ed0192d310a..5b1b0bb49be 100644 --- a/src/inet/visualizer/osg/networklayer/RoutingTableOsgVisualizer.h +++ b/src/inet/visualizer/osg/networklayer/RoutingTableOsgVisualizer.h @@ -8,6 +8,7 @@ #ifndef __INET_ROUTINGTABLEOSGVISUALIZER_H #define __INET_ROUTINGTABLEOSGVISUALIZER_H +#include #include #include "inet/visualizer/base/RoutingTableVisualizerBase.h"