Minor Changes

Author: rcosta358

liquidjava-verifier/src/main/java/liquidjava/diagnostics/LJDiagnostic.java

@@ -39,8 +39,8 @@ public String getCustomMessage() {
         return customMessage;
     }
 
-    public String getDetails() {
-        return hint != null ? hint : "";
+    public String getHint() {
+        return hint;
     }
 
     public SourcePosition getPosition() {
@@ -84,10 +84,10 @@ public String toString() {
             sb.append(snippet);
         }
 
-        // details
-        String details = getDetails();
-        if (!details.isEmpty()) {
-            sb.append(" --> ").append(String.join("\n     ", details.split("\n"))).append("\n");
+        // hint
+        String hint = getHint();
+        if (hint != null && !hint.isBlank()) {
+            sb.append(" --> ").append(String.join("\n     ", hint.split("\n"))).append("\n");
         }
 
         // location
@@ -100,9 +100,9 @@ public String toString() {
         if (declPos != null && declPos.getFile() != null && !declPos.equals(position)) {
             sb.append(Colors.CYAN).append("\n--> Refinement declared here:\n").append(Colors.RESET);
             String declarationSnippet = getSnippet(declPos, 1, 0, Colors.CYAN, null, true);
-            if (declarationSnippet != null) {
+            if (declarationSnippet != null)
                 sb.append(declarationSnippet);
-            }
+
             sb.append(declPos.getFile().getPath()).append(":").append(declPos.getLine()).append(Colors.RESET)
                     .append("\n");
         }

liquidjava-verifier/src/main/java/liquidjava/diagnostics/errors/RefinementError.java

@@ -45,9 +45,9 @@ public SourcePosition getDeclarationPosition() {
     }
 
     @Override
-    public String getDetails() {
+    public String getHint() {
         if (counterexample.isEmpty())
-            return "";
+            return null;
 
         String counterexampleString = counterexample.assignments().stream()
                 .map(a -> VariableFormatter.format(a.first()) + " == " + a.second())

liquidjava-verifier/src/main/java/liquidjava/diagnostics/warnings/ExternalMethodNotFoundWarning.java

@@ -34,7 +34,9 @@ public String[] getOverloads() {
     }
 
     @Override
-    public String getDetails() {
-        return overloads.length > 0 ? String.format("Available overloads:\n  %s", String.join("\n  ", overloads)) : "";
+    public String getHint() {
+        if (overloads.length == 0)
+            return null;
+        return String.format("Available overloads:\n  %s", String.join("\n  ", overloads));
     }
 }

liquidjava-verifier/src/test/java/liquidjava/rj_language/parsing/RefinementsParserTest.java

@@ -15,13 +15,13 @@ class RefinementsParserTest {
     void hintsArrowVsImplication() {
         SyntaxError e = assertThrows(SyntaxError.class,
                 () -> RefinementsParser.createAST("_ == true -> markSupported(this)", ""));
-        assertEquals("Logical implication is --> (two dashes), not ->", e.getDetails());
+        assertEquals("Logical implication is --> (two dashes), not ->", e.getHint());
     }
 
     @Test
     void hintsAssignVsEquals() {
         SyntaxError e = assertThrows(SyntaxError.class, () -> RefinementsParser.createAST("_ = 1", ""));
-        assertEquals("Predicates must be compared with == instead of =", e.getDetails());
+        assertEquals("Predicates must be compared with == instead of =", e.getHint());
     }
 
     @Test
@@ -33,7 +33,7 @@ void noHintForValidImplication() {
     @Test
     void noHintForUnrelatedSyntaxError() {
         SyntaxError e = assertThrows(SyntaxError.class, () -> RefinementsParser.createAST("a +", ""));
-        assertEquals("", e.getDetails());
+        assertEquals(null, e.getHint());
     }
 
     @Test