Commit 3823fe5
committed
harden(manifest): the xpkg path fills
`sourcesDeclared` distinguishes "no `sources` key" from `sources = []`, and the
xpkg descriptor parser filled the list without setting it. Harmless today — that
synthesiser refuses a descriptor with no sources and never calls
apply_defaults_and_infer — but a false flag beside a non-empty list is a trap:
the day that function runs on an xpkg manifest, its explicit list is replaced by
the default glob and every descriptor-described package quietly compiles the
wrong file set.sources and now says so1 parent b5be639 commit 3823fe5
1 file changed
Lines changed: 7 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1227 | 1227 | | |
1228 | 1228 | | |
1229 | 1229 | | |
| 1230 | + | |
| 1231 | + | |
| 1232 | + | |
| 1233 | + | |
| 1234 | + | |
| 1235 | + | |
| 1236 | + | |
1230 | 1237 | | |
1231 | 1238 | | |
1232 | 1239 | | |
| |||
0 commit comments