Commit 69be04c
committed
test(e2e): an empty --version is not an old client
252's guard compared `$MCPP_BOOT --version` against the PR binary's and treated
"different" as "found an old client". In CI that entry is an xvm SHIM, and a
shim resolves against the home it is asked in — under the e2e suite's
environment it answers `xlings: 'mcpp' is not installed` and prints nothing. The
empty string duly differed, so the test ran the real check against a binary that
cannot run at all and reported a COMPATIBILITY FAILURE against a package that is
perfectly readable. Three legs red for a reason that was in the test.
The guard now requires a version-SHAPED answer. Anything else means "no usable
old binary here", which is a note naming what it got, not a verdict — and the
static half (the generated manifest's sections are a subset of the pre-existing
vocabulary) still runs everywhere.
Consequence worth stating: the real old-client check runs where a released mcpp
binary is directly executable — locally, and in any job that points MCPP_BOOT at
one rather than at a shim. It passed against 2026.8.15.3.1 parent 0d871b3 commit 69be04c
1 file changed
Lines changed: 31 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
92 | 92 | | |
93 | 93 | | |
94 | 94 | | |
95 | | - | |
96 | | - | |
97 | | - | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
98 | 116 | | |
99 | 117 | | |
100 | 118 | | |
| |||
107 | 125 | | |
108 | 126 | | |
109 | 127 | | |
110 | | - | |
111 | | - | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
112 | 138 | | |
113 | 139 | | |
0 commit comments