quic: fix stream limits

Author: martenrichter

test/parallel/test-quic-h3-wt-bidi-from-client.mjs

@@ -53,9 +53,6 @@ const serverSessionOpened = Promise.withResolvers();
 
 
 const serverEndpoint = await listen(mustCall(async (ss) => {
-  ss.onstream = mustNotCall(async (stream) => {
-    console.log('Does nothing but is required! Fix me!');
-  });
   ss.onapplication = mustCall((aopts) => {
     assert.strictEqual(!aopts.enableDatagrams, false);
   });
@@ -91,7 +88,11 @@ const serverEndpoint = await listen(mustCall(async (ss) => {
     enableDatagrams: true,
     enableWebtransport: true
   },
-  transportParams: { maxDatagramFrameSize: 100 },
+  transportParams: { 
+    maxDatagramFrameSize: 1000,
+    initialMaxStreamsBidi: 100, // default value according to spec
+    initialMaxStreamsUni: 100, // especially important as limit default is 0
+  },
   onheaders: mustCall(function(headers) {
     try {
       assert.strictEqual(headers[':scheme'], 'https');
@@ -124,7 +125,11 @@ const clientSession = await connect(serverEndpoint.address, {
     enableDatagrams: true,
     enableWebtransport: true
   },
-  transportParams: { maxDatagramFrameSize: 1000 },
+  transportParams: { 
+    maxDatagramFrameSize: 1000,
+    initialMaxStreamsBidi: 100, // default value according to spec
+    initialMaxStreamsUni: 100, // especially important as limit default is 0
+  },
 });
 
 const webtransportSupport = Promise.withResolvers();

test/parallel/test-quic-h3-wt-unidi-from-client.mjs

@@ -55,9 +55,6 @@ const serverSessionRead = Promise.withResolvers();
 const readChunks = [];
 let serverSessionStream;
 const serverEndpoint = await listen(mustCall(async (ss) => {
-  ss.onstream = mustNotCall(async (stream) => {
-    console.log('Does nothing but is required! Fix me!');
-  });
   ss.onapplication = mustCall((aopts) => {
     assert.strictEqual(!aopts.enableDatagrams, false);
   });
@@ -100,7 +97,11 @@ const serverEndpoint = await listen(mustCall(async (ss) => {
     enableDatagrams: true,
     enableWebtransport: true
   },
-  transportParams: { maxDatagramFrameSize: 100 },
+  transportParams: { 
+    maxDatagramFrameSize: 100,
+    initialMaxStreamsBidi: 100, // default value according to spec
+    initialMaxStreamsUni: 100, // especially important as limit default is 0
+  },
   onheaders: mustCall(function(headers) {
     try {
       assert.strictEqual(headers[':scheme'], 'https');
@@ -128,7 +129,11 @@ const clientSession = await connect(serverEndpoint.address, {
     enableDatagrams: true,
     enableWebtransport: true
   },
-  transportParams: { maxDatagramFrameSize: 1000 },
+  transportParams: { 
+    maxDatagramFrameSize: 1000,
+    initialMaxStreamsBidi: 100, // default value according to spec
+    initialMaxStreamsUni: 100, // especially important as limit default is 0
+  },
 });
 
 const webtransportSupport = Promise.withResolvers();
@@ -156,7 +161,7 @@ clientSession.onstream = mustNotCall((stream) => {
 await clientSession.opened;
 await webtransportSupport.promise;
 // Now we open a webtransport session, which is actually
-// a special unidirectional stream
+// a special bidirectional stream
 const wtSessionStream = await clientSession.createBidirectionalStream({
   body: '',
 });
@@ -176,7 +181,7 @@ wtSessionStream.sendHeaders({
 });
 
 // Well let's get a unidi stream and send something
-const clientUnidiStream = await clientSession.createBidirectionalStream({
+const clientUnidiStream = await clientSession.createUnidirectionalStream({
   incremental: true,
   webtransportSession: wtSessionStream // Associate it with the sessionStream
 });
@@ -187,7 +192,6 @@ clientUnidiStream.closed.catch((error) => {
 // Next step send some data
 await serverSessionOpened.promise;
 
-
 const w = clientUnidiStream.writer;
 for (let i = 0; i < numChunks; i++) {
   const chunk = buildChunk(i);