From 68f0b76b8fec0950939da0f6cd29a8c0cf1656b8 Mon Sep 17 00:00:00 2001 From: Rian Stockbower Date: Mon, 29 Jun 2026 10:02:46 -0400 Subject: [PATCH 1/4] fix: consume keychain exists mitigation --- .goreleaser.yml | 5 +++-- go.mod | 2 +- go.sum | 2 ++ 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/.goreleaser.yml b/.goreleaser.yml index d2f5799d..f74c0996 100644 --- a/.goreleaser.yml +++ b/.goreleaser.yml @@ -44,8 +44,9 @@ builds: - -X github.com/open-cli-collective/codereview-cli/internal/version.Version={{.Version}} - -X github.com/open-cli-collective/codereview-cli/internal/version.Commit={{.Commit}} - -X github.com/open-cli-collective/codereview-cli/internal/version.Date={{.Date}} - # macOS code-signing — stable DR so Keychain "Always Allow" survives brew upgrade - # (cli-common distribution.md §2A). Logic + identity live in open-cli-collective/.github + # macOS code-signing — stable DR avoids ad-hoc identity churn, but self-signed + # builds still need the shared Keychain prompt mitigations described in + # cli-common/docs/distribution.md §2A. Logic + identity live in open-cli-collective/.github # (macos-codesign-setup), which exports CODESIGN_DARWIN_SCRIPT (absolute). Unset in # local builds → signing skipped. hooks: diff --git a/go.mod b/go.mod index 86dad2df..f288a3e8 100644 --- a/go.mod +++ b/go.mod @@ -11,7 +11,7 @@ require ( github.com/charmbracelet/lipgloss v1.1.0 github.com/creack/pty v1.1.24 github.com/google/uuid v1.6.0 - github.com/open-cli-collective/cli-common v0.4.0 + github.com/open-cli-collective/cli-common v0.4.1-0.20260629140122-9ab616283573 github.com/spf13/cobra v1.10.2 golang.org/x/sys v0.46.0 golang.org/x/term v0.44.0 diff --git a/go.sum b/go.sum index fbdd19e1..16dfbe3f 100644 --- a/go.sum +++ b/go.sum @@ -113,6 +113,8 @@ github.com/noamcohen97/touchid-go v0.3.0 h1:fcXxVCizysD7KHRR6hrURt3nyNIs5JBGSbOI github.com/noamcohen97/touchid-go v0.3.0/go.mod h1:X9MRNIBGEmPqwpDm1G3fQOAQX7fwBlhzUbnkDTxuta0= github.com/open-cli-collective/cli-common v0.4.0 h1:YkffqDW2OmFMWPqrT7m/yC3VoUKxGRAp26i2QZMYIWo= github.com/open-cli-collective/cli-common v0.4.0/go.mod h1:3AzjCT0V8xgslHlGi1+rUkcV+Vf5wONGwISQkufLZLQ= +github.com/open-cli-collective/cli-common v0.4.1-0.20260629140122-9ab616283573 h1:5+ad2Xvq9RHx/0YtGbs9crzq+BcBsfQRRVmlsfJC/Vo= +github.com/open-cli-collective/cli-common v0.4.1-0.20260629140122-9ab616283573/go.mod h1:3AzjCT0V8xgslHlGi1+rUkcV+Vf5wONGwISQkufLZLQ= github.com/opentracing/opentracing-go v1.2.0 h1:uEJPy/1a5RIPAJ0Ov+OIO8OxWu77jEv+1B0VhjKrZUs= github.com/opentracing/opentracing-go v1.2.0/go.mod h1:GxEUsuufX4nBwe+T+Wl9TAgYrxe9dPLANfrWvHYVTgc= github.com/pkg/errors v0.9.1 h1:FEBLx1zS214owpjy7qsBeixbURkuhQAwrK5UwLGTwt4= From 8025013401fbb3cb0b5b4b991fed1e5857b20234 Mon Sep 17 00:00:00 2001 From: Rian Stockbower Date: Mon, 29 Jun 2026 10:05:58 -0400 Subject: [PATCH 2/4] fix: repin cli-common keychain mitigation commit --- go.mod | 2 +- go.sum | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/go.mod b/go.mod index f288a3e8..3bcfafa1 100644 --- a/go.mod +++ b/go.mod @@ -11,7 +11,7 @@ require ( github.com/charmbracelet/lipgloss v1.1.0 github.com/creack/pty v1.1.24 github.com/google/uuid v1.6.0 - github.com/open-cli-collective/cli-common v0.4.1-0.20260629140122-9ab616283573 + github.com/open-cli-collective/cli-common v0.4.1-0.20260629140442-d94ebb08c917 github.com/spf13/cobra v1.10.2 golang.org/x/sys v0.46.0 golang.org/x/term v0.44.0 diff --git a/go.sum b/go.sum index 16dfbe3f..bff04b6a 100644 --- a/go.sum +++ b/go.sum @@ -115,6 +115,8 @@ github.com/open-cli-collective/cli-common v0.4.0 h1:YkffqDW2OmFMWPqrT7m/yC3VoUKx github.com/open-cli-collective/cli-common v0.4.0/go.mod h1:3AzjCT0V8xgslHlGi1+rUkcV+Vf5wONGwISQkufLZLQ= github.com/open-cli-collective/cli-common v0.4.1-0.20260629140122-9ab616283573 h1:5+ad2Xvq9RHx/0YtGbs9crzq+BcBsfQRRVmlsfJC/Vo= github.com/open-cli-collective/cli-common v0.4.1-0.20260629140122-9ab616283573/go.mod h1:3AzjCT0V8xgslHlGi1+rUkcV+Vf5wONGwISQkufLZLQ= +github.com/open-cli-collective/cli-common v0.4.1-0.20260629140442-d94ebb08c917 h1:5/tPbHJtT6gj1FGoJa5fjtYb+sPglcbbtKthO5QloTs= +github.com/open-cli-collective/cli-common v0.4.1-0.20260629140442-d94ebb08c917/go.mod h1:3AzjCT0V8xgslHlGi1+rUkcV+Vf5wONGwISQkufLZLQ= github.com/opentracing/opentracing-go v1.2.0 h1:uEJPy/1a5RIPAJ0Ov+OIO8OxWu77jEv+1B0VhjKrZUs= github.com/opentracing/opentracing-go v1.2.0/go.mod h1:GxEUsuufX4nBwe+T+Wl9TAgYrxe9dPLANfrWvHYVTgc= github.com/pkg/errors v0.9.1 h1:FEBLx1zS214owpjy7qsBeixbURkuhQAwrK5UwLGTwt4= From 73cb031c6638fe334d721ac7afe2dc51ed981b08 Mon Sep 17 00:00:00 2001 From: Rian Stockbower Date: Mon, 29 Jun 2026 10:12:42 -0400 Subject: [PATCH 3/4] fix: repin cli-common after nocgo metadata fix --- go.mod | 2 +- go.sum | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/go.mod b/go.mod index 3bcfafa1..8a6b8c39 100644 --- a/go.mod +++ b/go.mod @@ -11,7 +11,7 @@ require ( github.com/charmbracelet/lipgloss v1.1.0 github.com/creack/pty v1.1.24 github.com/google/uuid v1.6.0 - github.com/open-cli-collective/cli-common v0.4.1-0.20260629140442-d94ebb08c917 + github.com/open-cli-collective/cli-common v0.4.1-0.20260629140955-3d3f982b83c3 github.com/spf13/cobra v1.10.2 golang.org/x/sys v0.46.0 golang.org/x/term v0.44.0 diff --git a/go.sum b/go.sum index bff04b6a..7172dca3 100644 --- a/go.sum +++ b/go.sum @@ -117,6 +117,8 @@ github.com/open-cli-collective/cli-common v0.4.1-0.20260629140122-9ab616283573 h github.com/open-cli-collective/cli-common v0.4.1-0.20260629140122-9ab616283573/go.mod h1:3AzjCT0V8xgslHlGi1+rUkcV+Vf5wONGwISQkufLZLQ= github.com/open-cli-collective/cli-common v0.4.1-0.20260629140442-d94ebb08c917 h1:5/tPbHJtT6gj1FGoJa5fjtYb+sPglcbbtKthO5QloTs= github.com/open-cli-collective/cli-common v0.4.1-0.20260629140442-d94ebb08c917/go.mod h1:3AzjCT0V8xgslHlGi1+rUkcV+Vf5wONGwISQkufLZLQ= +github.com/open-cli-collective/cli-common v0.4.1-0.20260629140955-3d3f982b83c3 h1:R5HPK2CWVuDFO/pwsKa4hkpttsdGs/+O+FJwq1qDR/Y= +github.com/open-cli-collective/cli-common v0.4.1-0.20260629140955-3d3f982b83c3/go.mod h1:3AzjCT0V8xgslHlGi1+rUkcV+Vf5wONGwISQkufLZLQ= github.com/opentracing/opentracing-go v1.2.0 h1:uEJPy/1a5RIPAJ0Ov+OIO8OxWu77jEv+1B0VhjKrZUs= github.com/opentracing/opentracing-go v1.2.0/go.mod h1:GxEUsuufX4nBwe+T+Wl9TAgYrxe9dPLANfrWvHYVTgc= github.com/pkg/errors v0.9.1 h1:FEBLx1zS214owpjy7qsBeixbURkuhQAwrK5UwLGTwt4= From 4f05f434e37ca9b3f0fac1430e58f3eda07d25e1 Mon Sep 17 00:00:00 2001 From: Rian Stockbower Date: Tue, 30 Jun 2026 09:48:58 -0400 Subject: [PATCH 4/4] fix: use cli-common v0.4.1 --- go.mod | 2 +- go.sum | 10 ++-------- 2 files changed, 3 insertions(+), 9 deletions(-) diff --git a/go.mod b/go.mod index 8a6b8c39..9d25995e 100644 --- a/go.mod +++ b/go.mod @@ -11,7 +11,7 @@ require ( github.com/charmbracelet/lipgloss v1.1.0 github.com/creack/pty v1.1.24 github.com/google/uuid v1.6.0 - github.com/open-cli-collective/cli-common v0.4.1-0.20260629140955-3d3f982b83c3 + github.com/open-cli-collective/cli-common v0.4.1 github.com/spf13/cobra v1.10.2 golang.org/x/sys v0.46.0 golang.org/x/term v0.44.0 diff --git a/go.sum b/go.sum index 7172dca3..92d0e4e0 100644 --- a/go.sum +++ b/go.sum @@ -111,14 +111,8 @@ github.com/niemeyer/pretty v0.0.0-20200227124842-a10e7caefd8e h1:fD57ERR4JtEqsWb github.com/niemeyer/pretty v0.0.0-20200227124842-a10e7caefd8e/go.mod h1:zD1mROLANZcx1PVRCS0qkT7pwLkGfwJo4zjcN/Tysno= github.com/noamcohen97/touchid-go v0.3.0 h1:fcXxVCizysD7KHRR6hrURt3nyNIs5JBGSbOIidD/3wo= github.com/noamcohen97/touchid-go v0.3.0/go.mod h1:X9MRNIBGEmPqwpDm1G3fQOAQX7fwBlhzUbnkDTxuta0= -github.com/open-cli-collective/cli-common v0.4.0 h1:YkffqDW2OmFMWPqrT7m/yC3VoUKxGRAp26i2QZMYIWo= -github.com/open-cli-collective/cli-common v0.4.0/go.mod h1:3AzjCT0V8xgslHlGi1+rUkcV+Vf5wONGwISQkufLZLQ= -github.com/open-cli-collective/cli-common v0.4.1-0.20260629140122-9ab616283573 h1:5+ad2Xvq9RHx/0YtGbs9crzq+BcBsfQRRVmlsfJC/Vo= -github.com/open-cli-collective/cli-common v0.4.1-0.20260629140122-9ab616283573/go.mod h1:3AzjCT0V8xgslHlGi1+rUkcV+Vf5wONGwISQkufLZLQ= -github.com/open-cli-collective/cli-common v0.4.1-0.20260629140442-d94ebb08c917 h1:5/tPbHJtT6gj1FGoJa5fjtYb+sPglcbbtKthO5QloTs= -github.com/open-cli-collective/cli-common v0.4.1-0.20260629140442-d94ebb08c917/go.mod h1:3AzjCT0V8xgslHlGi1+rUkcV+Vf5wONGwISQkufLZLQ= -github.com/open-cli-collective/cli-common v0.4.1-0.20260629140955-3d3f982b83c3 h1:R5HPK2CWVuDFO/pwsKa4hkpttsdGs/+O+FJwq1qDR/Y= -github.com/open-cli-collective/cli-common v0.4.1-0.20260629140955-3d3f982b83c3/go.mod h1:3AzjCT0V8xgslHlGi1+rUkcV+Vf5wONGwISQkufLZLQ= +github.com/open-cli-collective/cli-common v0.4.1 h1:6oNaUVmMtXWi4pJn1X+W6KZVDP/WAJwbyZUyxYpGdbQ= +github.com/open-cli-collective/cli-common v0.4.1/go.mod h1:3AzjCT0V8xgslHlGi1+rUkcV+Vf5wONGwISQkufLZLQ= github.com/opentracing/opentracing-go v1.2.0 h1:uEJPy/1a5RIPAJ0Ov+OIO8OxWu77jEv+1B0VhjKrZUs= github.com/opentracing/opentracing-go v1.2.0/go.mod h1:GxEUsuufX4nBwe+T+Wl9TAgYrxe9dPLANfrWvHYVTgc= github.com/pkg/errors v0.9.1 h1:FEBLx1zS214owpjy7qsBeixbURkuhQAwrK5UwLGTwt4=