From 8c9a50cbf8717d33ec312fbc1652d713213b6a28 Mon Sep 17 00:00:00 2001 From: lacatoire Date: Fri, 7 Aug 2026 16:50:58 +0200 Subject: [PATCH] Fix parameter name in the convert_uudecode() warning The warning names $data, but the parameter has been declared as $string since the stub was introduced, so following the message and calling convert_uudecode(data: ...) raises Error: Unknown named parameter $data. The message is a literal rather than a generated one, which is why it did not follow the parameter. Three tests pinning the old wording are updated. --- ext/standard/tests/strings/bug67252.phpt | 2 +- ext/standard/tests/strings/uuencode.phpt | 4 ++-- ext/standard/uuencode.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/ext/standard/tests/strings/bug67252.phpt b/ext/standard/tests/strings/bug67252.phpt index bd758a1c79fd..60ae319f76d2 100644 --- a/ext/standard/tests/strings/bug67252.phpt +++ b/ext/standard/tests/strings/bug67252.phpt @@ -8,5 +8,5 @@ var_dump(convert_uudecode($a)); ?> --EXPECTF-- -Warning: convert_uudecode(): Argument #1 ($data) is not a valid uuencoded string in %s on line %d +Warning: convert_uudecode(): Argument #1 ($string) is not a valid uuencoded string in %s on line %d bool(false) diff --git a/ext/standard/tests/strings/uuencode.phpt b/ext/standard/tests/strings/uuencode.phpt index d03c2b1bf0f3..82ded4165769 100644 --- a/ext/standard/tests/strings/uuencode.phpt +++ b/ext/standard/tests/strings/uuencode.phpt @@ -29,9 +29,9 @@ string(36) "6;F]T('9E