Remote access continues to be enabled even after unticking the option

[returnDanilo]

Steps to reproduce:

1. Download and launch phyphox 1.2.0
2. Choose one of the options, say, Magnetometer
3. Press the three-dotted button on the top right
4. Select 'Allow remote access'
5. Press OK
6. Press the play button
7. In a browser, open the url for remote access. say, 192.168.0.2:8080
8. Verify you are receiving experiment data
9. Go back to the app and press the three dots again
10. Tap on 'Allow remote access' again, so as to untick the box.
11. Tap the three dots again and verify the 'Allow remote access' option is unticked.
12. Notice how the warning on the remote access being enabled is gone as well.
13. Go back to the browser and verify that you are still receiving data.

Expected behavior:

Expected for the app to stop sending data after unchecking the box.

What actually happened:

The app will continue to send data even after unchecking the box, while also hiding the warning the feature is enabled.

Other notes:

I noticed that disabling the box will prevent me from opening a new page on the browser to see the remote data, but if I keep the old page open, I can still see the data being sent through it, as described in the steps above.

[Staacks]

Thanks for reporting. I can reproduce it immediately, but I have to admit that I do not entirely understand it. As you describe, after unticking the box I can no longer open a new connection from a different broser or another tab, but the old connection remains available. Even stranger: When leavin the experiment to the main menu, the old connection still remains available with the old data, which phyphox itself no longer has. I also noticed that our version of JLHTTP is quite outdated, so some maintanence is in order.

I will look into it and make sure to fix the issue for the next release.

[hiSandog]

Remote access should probably have one source of truth for enabled state, and UI changes should immediately stop the server/listener when the option is unticked. A regression test could enable remote access, verify the service/socket is active, disable it, and assert both the preference and network listener are off after an activity restart. That would catch a stale service continuing to run even though the settings UI says it is disabled.