From 838af050c05b9ac57ca76f83201cb59966a91c60 Mon Sep 17 00:00:00 2001 From: Joshua Sierles Date: Wed, 16 Aug 2023 14:44:37 +0200 Subject: [PATCH 1/2] Update log shipper docs to ensure that no public access is granted by default --- going-to-production/monitoring/exporting-logs.html.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/going-to-production/monitoring/exporting-logs.html.md b/going-to-production/monitoring/exporting-logs.html.md index 7eefd1c16e..815e135057 100644 --- a/going-to-production/monitoring/exporting-logs.html.md +++ b/going-to-production/monitoring/exporting-logs.html.md @@ -32,7 +32,7 @@ mkdir logshippper cd logshippper # Create the app but don't deploy just yet -fly launch --no-deploy --image ghcr.io/superfly/fly-log-shipper:latest +fly launch --no-deploy --no-public-ips --image ghcr.io/superfly/fly-log-shipper:latest # Set some secrets. The secret / env var you set # determines which "sinks" are configured From 558a15a2c19adef2e292b21fc49456048bc151e4 Mon Sep 17 00:00:00 2001 From: Joshua Sierles Date: Wed, 16 Aug 2023 15:24:58 +0200 Subject: [PATCH 2/2] Use --no-public-ips with 'fly deploy' as well --- .../monitoring/exporting-logs.html.md | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/going-to-production/monitoring/exporting-logs.html.md b/going-to-production/monitoring/exporting-logs.html.md index 815e135057..a8e07b93c3 100644 --- a/going-to-production/monitoring/exporting-logs.html.md +++ b/going-to-production/monitoring/exporting-logs.html.md @@ -32,7 +32,7 @@ mkdir logshippper cd logshippper # Create the app but don't deploy just yet -fly launch --no-deploy --no-public-ips --image ghcr.io/superfly/fly-log-shipper:latest +fly launch --no-deploy --image ghcr.io/superfly/fly-log-shipper:latest # Set some secrets. The secret / env var you set # determines which "sinks" are configured @@ -43,18 +43,12 @@ fly secrets set LOGTAIL_TOKEN= You can configure as many providers as you'd like by adding more secrets. The secrets needed are determined by [which provider(s)](https://github.com/superfly/fly-log-shipper#provider-configuration) you want to use. -Before launching your application, you should edit the generated `fly.toml` file and delete the entire `[[services]]` section. Replace it with this: +Before launching your application, you should edit the generated `fly.toml` file and delete the entire `[[http_service]]` section. -```toml -[[services]] - http_checks = [] - internal_port = 8686 -``` - -Then you can deploy it: +Then you can deploy: ```cmd -fly deploy +fly deploy --no-public-ips ``` ## Shipping Specific Logs