Skip to content

Pre-commit hook check doesn't work on suggestions made via the GitHub web UI #231

Description

@sumau

The pre-commit hook check doesn't work on suggestions made via the GitHub web UI because it's missing the signed by DBT commit message. See #229 as an example.

See https://ditdigitalteam.slack.com/archives/C0A2MV5BTFY/p1784213847243299 where this was first raised.

Suggestion by @chopkinsmade :

There is an error message about needing to set the GH_TOKEN environment variable, we could try setting that as part of the workflow yaml and see if it fixes it. I'm doubtful it will, so an alternative would be to amend that pre-commit check and try and inspect the incoming params to dect if the source is via the Update button from the PR. We have the check to ignore dependabot commit: if: ${{ github.actor != 'dependabot[bot]' }}

Work-around until issue resolved:

As suggested by @nicopicchio , pull the branch with the suggestions, add an empty commit and push back:

git commit --allow-empty -m "Empty commit to resolve pre-commit hook check error"

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions