Skip to content

refactor(quick-start): align with six-node workflow controller - #95

Merged
xyh202131 merged 13 commits into
1024XEngineer:mainfrom
xyh202131:feat/quick-start-animation-review
Aug 11, 2026
Merged

refactor(quick-start): align with six-node workflow controller#95
xyh202131 merged 13 commits into
1024XEngineer:mainfrom
xyh202131:feat/quick-start-animation-review

Conversation

@xyh202131

@xyh202131 xyh202131 commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

本次更新

  • 恢复当前主工作区的绿色创作台 Quick Start 界面,不再使用 8 月 8 日的旧白色简化页面。
  • Quick Start 与 Workflow Editor 共用同一个六节点 Workflow Controller,界面形式不同但推进规则一致。
  • 角色母版确认后生成动作首帧,自动选择当前可用的 video-cropping 路线,再生成并审核 32 帧完整动画。
  • 页面订阅 Service,Service 订阅 Controller;修改方法只返回 Promise<void>,持续数据统一从订阅获得。
  • Generation 调用对齐后端的 character_image / character_action 契约,并校验返回动作类型与当前节点一致。
  • 支持上传角色母版:上传成功后跳过角色图生成,输入文字直接作为动作描述继续生成资产。
  • App 在认证完成后装配真实 Generation 与 Media 适配器;用户身份由统一 Bearer 会话交给后端解析。
  • 多个 Action 使用相互独立的四节点分支;已发布 Action 删除后保留生成与审核历史。

依赖与边界

  • 已同步最新 main、Media 上传能力与 feat(generation): align validated SSE adapter with backend tasks #110 的 Generation/SSE 契约。
  • Quick Start 负责自然语言输入和自动决策,节点规则仍由前端 Workflow Controller 负责。
  • WorkflowRun 持久化走后端 CRUD,不恢复本地 Store 或第二套状态机。
  • 3d-to-2d 只保留选择入口,后端接口未提供前不伪装成功。

验证

  • 全量前端测试:33 个测试文件、220 条测试通过。
  • TypeScript 类型检查、oxlint、目标文件格式检查和生产构建通过。

@vercel

vercel Bot commented Aug 4, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
windup Ready Ready Preview Aug 11, 2026 10:56am

@fennoai fennoai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found one issue in this review.

Verification note: local npm test -- ... and npm run typecheck could not run in this workspace because the invoked vitest and tsc commands failed with Permission denied.

Comment thread frontend/src/entities/workflow-run/service/workflow-run-service.ts Outdated
@xyh202131
xyh202131 force-pushed the feat/quick-start-animation-review branch from 28a9451 to 30e2d89 Compare August 8, 2026 08:22
@xyh202131 xyh202131 changed the title feat(quick-start): add guided creation and animation review refactor(quick-start): align with five-node workflow controller Aug 8, 2026
@xyh202131
xyh202131 force-pushed the feat/quick-start-animation-review branch from 30e2d89 to 291e948 Compare August 8, 2026 08:30
@xyh202131
xyh202131 force-pushed the feat/quick-start-animation-review branch from 291e948 to aa75e23 Compare August 8, 2026 08:35
@xyh202131 xyh202131 changed the title refactor(quick-start): align with five-node workflow controller refactor(quick-start): align with six-node workflow controller Aug 8, 2026
@huyanxius
huyanxius requested a review from nighca August 10, 2026 08:23
@xyh202131

Copy link
Copy Markdown
Contributor Author

@fennoai 复审

@fennoai

fennoai Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Review Complete

复审反馈已提交:

  • 发布状态在 Playtest 写入前落库,后续失败后无法重试。
  • 旧 Run 恢复时按项目最后一个角色回退,可能错绑角色。
  • 现有角色的 Run 只查询第一页 100 条,可能创建重复工作流。

验证说明:针对性 Vitest 与 TypeScript 检查未能启动,工作区缺少可执行的 vitest/tsc 二进制(Permission denied)。

View job run

@fennoai fennoai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

复审发现 3 个需要修复的业务一致性问题,建议合并前处理。未发现明显的注入、认证绕过或性能热点问题。

Comment thread frontend/src/pages/quick-start/service.ts Outdated
Comment thread frontend/src/pages/quick-start/service.ts Outdated
Comment thread frontend/src/pages/quick-start/service.ts
@huyanxius

Copy link
Copy Markdown
Collaborator

除了 UI 后面我们再调整,我这边没有大问题了,请导师再审审吧
@nighca

@xyh202131
xyh202131 merged commit 459bf3e into 1024XEngineer:main Aug 11, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants