Skip to content

feat(reminder): wire createAppServices and AppRuntime - #181

Open
gac0812 wants to merge 4 commits into
1024XEngineer:mainfrom
gac0812:feat/reminder-app-wiring
Open

feat(reminder): wire createAppServices and AppRuntime#181
gac0812 wants to merge 4 commits into
1024XEngineer:mainfrom
gac0812:feat/reminder-app-wiring

Conversation

@gac0812

@gac0812 gac0812 commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Summary

  • 增加应用组合根 createAppServices:装配全部 reminder mock ports,并返回 reminder / reminderPorts / runtime
  • 增加通用生命周期协调器 AppRuntime:按序 start 模块;若后序模块失败,则回滚已启动模块的 stop。
  • 这是 feat(reminder): 落地本地提醒端口、契约与 mock 适配器 #177 拆分交付的最后一层;合入后即可在本地用 mock 组合验证 reminder 启动/停止边界。

Related issue

Closes #177

Scope

  • frontend/src/app/composition/createAppServices.ts
  • frontend/src/app/orchestration/AppRuntime.ts

Out of scope

  • 真实平台 SDK、触发算法、UI 页面改动

Compose mock reminder ports and coordinate runtime start/stop with rollback.

Closes 1024XEngineer#177
@vercel

vercel Bot commented Aug 10, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
timeflow Ready Ready Preview Aug 11, 2026 8:44am

Bring in domain, ports, and local mocks from 1024XEngineer#178/1024XEngineer#179/1024XEngineer#180 so CI can resolve composition imports.
@gac0812
gac0812 marked this pull request as ready for review August 11, 2026 08:34

@fennoai fennoai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review summary

发现 3 个生命周期正确性问题,详见行内评论。

验证:固定范围的 git diff --check 通过。未能运行前端 typecheck/tests,因为工作区未安装可用的前端依赖(tsc 不可执行且 TypeScript 模块不存在)。

View job run

Comment thread frontend/src/app/orchestration/AppRuntime.ts
Comment thread frontend/src/app/orchestration/AppRuntime.ts Outdated
Comment thread frontend/src/app/orchestration/AppRuntime.ts
Queue start/stop on a shared promise chain, and always attempt to stop
every started module on rollback or shutdown while preserving/aggregating
errors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(reminder): 落地本地提醒端口、契约与 mock 适配器

1 participant