Update localstack plugin to use LOCALSTACK_AUTH_TOKEN#428
Conversation
|
Thanks for updating the LocalStack plugin for auth tokens, and thank you for your patience. A few changes before merge: Env-var mapping
Auth gating Please add Optional: add Happy to take another look once those are in! |
|
Thanks @scottisloud , I am afk at the moment but I'll make these changes in a few weeks |
84fc6c4 to
e3d1768
Compare
|
Thanks @scottisloud for the review comments. I have implemented the changes you suggested. We have stopped supporting API keys entirely (they are no longer given out by our authentication system), so I have removed the api key path altogether. |
|
Hi @simonrw I'll merge this shortly. Thanks for the patience here, and for the careful follow-up. |
scottisloud
left a comment
There was a problem hiding this comment.
LGTM!
Thanks again, and keep your eyes out for this to show up in a future release of the 1Password CLI!
Overview
LocalStack is migrating to use auth tokens instead of api keys. This should be reflected in the 1Password LocalStack shell plugin.
See the first item in the LocalStack v3.0.0 release notes miscellaneous section.
Updates the plugin created in #371
Type of change
How To Test
Changelog
The LocalStack plugin now uses
LOCALSTACK_AUTH_TOKENinstead ofLOCALSTACK_API_KEY