[FMV] Add support for more features - #444
Conversation
|
I think it would make sense to split the "bug fix" part into a separate patch. |
AlfieRichardsArm
left a comment
AlfieRichardsArm
left a comment
There was a problem hiding this comment.
LGTM but I think this ought to wait for #441 so this can get its own FMV support version tick
| | sme2p1 | sme2 | | ||
| | sme2p2 | sme2p1 | | ||
| | sve2p1 | sve2 | | ||
| | sve2p2 | sve2p1 | |
There was a problem hiding this comment.
Not a bug, but I do wonder
As sve2p2 requires armv9.5 is it worth (for FMV) implying everything thing that armv9.5 implies? That is not something we do for architecture options but it feels like there may be more to loose with FMV as it is more likely to be enabled via target_version (sve2p2) as opposed to -march-armv9.5-a+sve2p2 or -mcpu?
There was a problem hiding this comment.
My main concern with this is that we can have situations where features added as optional from certain version will be moved and added as optional from earlier architecture versions in later releases.
3 participants
The goal of this patch is to propose new features for function multi versioning. This should allow users to use FMV with newer features.
This patch also fixes a bug in register name for SME2 feature register.