feat: improved ux#2382
Conversation
Greptile SummaryThis PR improves the UX around quick tools visibility and fixes offline terminal creation. The
Confidence Score: 5/5The changes are safe to merge — all three functional areas (offline terminal fix, quick-tools visibility, plugin vendoring) are self-contained and the implementation is consistent across the affected call sites. The localhost → 127.0.0.1 fix is a well-understood loopback change applied uniformly to all four affected URLs. The hideQuickTools feature is correctly enforced at every entry point: tab switch (EditorFile.makeActive), initial render (applySettings.afterRender), and the setting-change handler (appSettings.js). The setHeight function also carries a redundant guard for safety. Default-value changes affect new installs only. The only observation is that the vendored plugin copy is frozen at 3.3.1 and will need manual updates for future upstream fixes. No files require special attention. package.json is worth noting because the vendored plugin will not automatically receive upstream updates. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[User switches tab] --> B[EditorFile.makeActive called]
B --> C[switchFile updates editorManager.activeFile]
C --> D{this.hideQuickTools?}
D -- Yes\nMedia / Welcome / Page --> E[Add hide class to toggler]
E --> F[setTimeout 300ms remove toggler from DOM]
F --> G[actions set-height height:0 save:false]
D -- No\nNormal editor file --> H{appSettings.floatingButton?}
H -- true --> I[Remove hide class, re-append toggler]
H -- false --> J[Leave toggler hidden]
I --> K[actions set-height height:savedQuickTools save:false]
J --> K
K --> L[setHeight checks activeFile.hideQuickTools as safety guard]
L --> M[Footer height updated]
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
A[User switches tab] --> B[EditorFile.makeActive called]
B --> C[switchFile updates editorManager.activeFile]
C --> D{this.hideQuickTools?}
D -- Yes\nMedia / Welcome / Page --> E[Add hide class to toggler]
E --> F[setTimeout 300ms remove toggler from DOM]
F --> G[actions set-height height:0 save:false]
D -- No\nNormal editor file --> H{appSettings.floatingButton?}
H -- true --> I[Remove hide class, re-append toggler]
H -- false --> J[Leave toggler hidden]
I --> K[actions set-height height:savedQuickTools save:false]
J --> K
K --> L[setHeight checks activeFile.hideQuickTools as safety guard]
L --> M[Footer height updated]
Reviews (6): Last reviewed commit: "feat(quicktools): hide quicktools on med..." | Re-trigger Greptile |
b412ac1 to
4aca7e8
Compare
4aca7e8 to
96b2399
Compare
…efault, and add search button
96b2399 to
807cb60
Compare
Closes #2357