Skip to content

Fix truncated unit test summary trace - #53

Open
dougwhite wants to merge 1 commit into
ActianCorp:masterfrom
dougwhite:master
Open

Fix truncated unit test summary trace#53
dougwhite wants to merge 1 commit into
ActianCorp:masterfrom
dougwhite:master

Conversation

@dougwhite

Copy link
Copy Markdown

Problem

For larger test suites, the plain text test summary can be truncated in the trace output. Here is the example output from my test runs:

TestSuite orapi_tests DONE.
[Mon Jun 15 18:10:44 2026] === Skipped Tests ===
[Mon Jun 15 18:10:44 2026] test_existing_file_is_appended test_uc_conflict_logger.test_existing_file_is_appended() (line 104): 
	Set C_SKIP_FILESYSTEM_TESTS to 0 to run this test
[Mon Jun 15 18:10:44 2026] test_new_file_is_created test_uc_conflict_logger.test_new_file_is_created() (line 55): 
	Set C_SKIP_FILESYSTEM_TESTS to 0 to run this test
[Mon Jun 15 18:10:44 2026] test_problems_return_errors test_uc_conflict_logger.test_problems_return_errors() (line 158): 
	Set C_SKIP_FILESYSTEM_TESTS to 0 to run this test
[Mon Jun 15 18:10:44 2026] ======================================================================
test_migration: TestsRun=6, Time_in_ms=187, Failures=0, Errors=0, Skipped=0
test_p4_check_sql: TestsRun=9, Time_in_ms=250, Failures=0, Errors=0, Skipped=0
test_uc_orapi: TestsRun=13, Time_in_ms=203, Failures=0, Errors=0, Skipped=0
test_logging: TestsRun=5, Time_in_ms=16, Failures=0, Errors=0, Skipped=0
test_ep: TestsRun=6, Time_in_ms=0, Failures=0, Errors=0, Skipped=0
test_env: TestsRun=3, Time_in_ms=62, Failures=0, Errors=0, Skipped=0
test_api_row: TestsRun=25, Time_in_ms=141, Failures=0, Errors=0, Skipped=0
test_uc_api_response: TestsRun=6, Time_in_ms=31, Failures=0, Errors=0, Skipped=0
test_service_endpoints: TestsRun=30, Time_in_ms=156, Failures=0, Errors=0, Skipped=0
test_msales_api_basics: TestsRun=2, Time_in_ms=172, Failures=0, Errors=0, Skipped=0
test_model_update: TestsRun=16, Time_in_ms=312, Failures=0, Errors=0, Skipped=0
test_msales_catalog: TestsRun=14, Time_in_ms=172, Failures=0, Errors=0, Skipped=0
test_msales_customer_pricelist: TestsRun=5, Time_in_ms=78, Failures=0, Errors=0, Skipped=0
test_msales_enduser: TestsRun=7, Time_in_ms=156, Failures=0, Errors=0, Skipped=0
test_msales_rep: TestsRun=10, Time_in_ms=109, Failures=0, Errors=0, Skipped=0
test_uc_conflict_logger: TestsRun=7, Time_in_ms=47, Failures=0, Errors=0, Skipped=3
test_uc_conflict_record: TestsRun=3, Time_in_ms=109, Failures=0, Errors=0, Skipped=0
test_model_update_ui: TestsRun=20, Time_in_ms=172, Failures=0, Errors=0, Skipped=0
test_update_list: TestsRun=12, Time_in_ms=188, Failures=0, Errors=0, Skipped=0
test_uc_sync_item: TestsRun=35, Time_in_ms=250, Failures=0, Errors=0, Skipped=0
test_uc_sync_list: TestsRun=25, Time_in_ms=281, Failures=0, Errors=0, Skipped=0
test_uc_batch_list: TestsRun=16, Time_in_ms=109, Failures=0, Errors=0, Skipped=0
test_uc_job: TestsRun=10, Time_in_ms=188, Failures=0, Errors=0, Skipped=0
test_p4_launch_job: TestsRun=11, Time_in_ms=312, Failures=0, Errors=0, Skipped=0
SUMMARY FOR TESTSUITE orap
[Mon Jun 15 18:10:44 2026] Fetching app_exithdl from image . . . done.

The summary line should have total number of test runs / failures etc.

Cause

The full report was being concatenated into a single text= trace call, hitting the OpenROAD trace varchar limit.

Fix

Trace the separator lines separately and output the result StringObject directly.

Verification

When I export the UnitTestFramework application from OpenROAD 12.0 my xml file is completely different than the one is the repo. 🤷

So I made the change to the flat xml file on disk and then re-imported into OpenROAD and it appears to be working as expected. All tests still passing and the message is no longer truncated.

@clach04 clach04 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to explain the problem AND provide a fix. Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants