Fix truncated unit test summary trace - #53
Open
dougwhite wants to merge 1 commit into
Open
Conversation
clach04
approved these changes
Jun 16, 2026
clach04
left a comment
Member
There was a problem hiding this comment.
Thanks for taking the time to explain the problem AND provide a fix. Looks good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
For larger test suites, the plain text test summary can be truncated in the trace output. Here is the example output from my test runs:
The summary line should have total number of test runs / failures etc.
Cause
The full report was being concatenated into a single
text=trace call, hitting the OpenROAD trace varchar limit.Fix
Trace the separator lines separately and output the result
StringObjectdirectly.Verification
When I export the UnitTestFramework application from OpenROAD 12.0 my xml file is completely different than the one is the repo. 🤷
So I made the change to the flat xml file on disk and then re-imported into OpenROAD and it appears to be working as expected. All tests still passing and the message is no longer truncated.