D-MBX-A6 output overhaul: StrategyOutcome carrier retires the dead-store _reliability#711
Conversation
…ore _reliability
StyleStrategy::plan() computed a style-conditioned reliability and discarded it
(`let _reliability = …`) because PlanInput had nowhere to carry a cognitive
outcome, and faking a KanbanMove/commit would be theatre. Add an honest carrier.
- traits.rs: `StrategyOutcome { reliability: f32, intended_move: Option<KanbanMove> }`
+ additive `PlanInput.outcome: Option<StrategyOutcome>` (default None, threaded
unchanged by every pass-through strategy).
- style_strategy.rs: plan() now surfaces the reliability + an INTENDED move —
Planning→CognitiveWork (a legal Rubicon edge), mailbox 0 / cycle 0 (the
zero-fallback bootstrap owner, write-on-behalf, not as ourselves; the live
owner rebinds on adoption), libet -550_000 (Σ-commit anchor), exec Elixir (the
backend reliability_of actually ran). The plan itself stays a pure pass-through
(out.plan.is_none() still asserted) — this is a SURFACE, not an emit/commit.
- 6 in-crate PlanInput{} literals gain `outcome: None`; the other ~15 plan()
impls return Ok(input) untouched.
Gating: UNBLOCKED — no classid mint (pairs an existing f32 with the already-minted
contract KanbanMove), not the OQ-11.7 five-phase cutover. Deferred: thread the
outcome OUT of compose_and_execute, promote StrategyOutcome to contract::kanban on
first cross-bridge read, and the owner-consume/advance edge.
Tests: 216 lib + 4 probe green; clippy -D warnings exit 0; fmt clean.
Board: EPIPHANIES E-STRATEGY-OUTCOME-CARRIER-1, STATUS_BOARD D-MBX-A6-P3b,
D-MBX-COMPLETION-MAP, AGENT_LOG.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Awg6TXocHcwTtc6eGsHcdD
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_df9827f9-4755-4244-9015-f8a60d4c34ee) |
|
Warning Review limit reached
Next review available in: 14 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (10)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
What
The planner-internal, unblocked slice of D-MBX-A6-P3: give
StyleStrategyan honest carrier for the style-conditioned reliability it computes, instead of dead-storing it (let _reliability = …, the exact theatre the council flagged).Why it was a dead store
StyleStrategy::plan()computes a style-conditioned reliability but discarded it, because theplan()return typePlanInput { plan, context }had nowhere to carry a cognitive outcome — and faking aKanbanMove/commit would be theatre.The change
traits.rs—StrategyOutcome { reliability: f32, intended_move: Option<KanbanMove> }+ additivePlanInput.outcome: Option<StrategyOutcome>(defaultNone, threaded unchanged by every pass-through strategy).style_strategy.rs—plan()now surfaces the reliability + an intended move:Planning → CognitiveWork(a legal Rubicon edge),mailbox 0/cycle 0(the zero-fallback bootstrap owner — write-on-behalf, not as ourselves; the liveMailboxSoaOwnerrebinds on adoption),libet -550_000(Σ-commit anchor),exec Elixir(the backendreliability_ofactually ran). The plan itself stays a pure pass-through —out.plan.is_none()is still asserted. This is a SURFACE, not an emit/commit/advance.PlanInput { … }literals gainoutcome: None; the other ~15plan()impls returnOk(input)untouched (additive field, no trait-signature change).Gating — UNBLOCKED
No classid mint (pairs an existing
f32with the already-minted contractKanbanMove), and not the OQ-11.7 five-phase cutover. Deferred next nodes: thread the outcome OUT ofcompose_and_execute(acompose_and_collect()sibling), promoteStrategyOutcometocontract::kanbanon first cross-bridge read, and the owner-consume/advance edge (OQ-11.7).Verification
cargo test -p lance-graph-planner→ 216 lib + 4 probe tests green.cargo clippy -p lance-graph-planner -- -D warnings→ exit 0.cargo fmt -p lance-graph-planner→ clean.plan_is_pure_passthrough_until_emit_edge_landsrewritten →plan_surfaces_outcome_without_mutating_the_plan(plan stillNone; outcome shape + legal-edge asserted).Board hygiene (same commit)
EPIPHANIES
E-STRATEGY-OUTCOME-CARRIER-1, STATUS_BOARDD-MBX-A6-P3brow,D-MBX-COMPLETION-MAP.mdtee-append,AGENT_LOG.mdentry.🤖 Generated with Claude Code
https://claude.ai/code/session_01Awg6TXocHcwTtc6eGsHcdD
Generated by Claude Code