Skip to content

D-MBX-A6 output overhaul: StrategyOutcome carrier retires the dead-store _reliability#711

Merged
AdaWorldAPI merged 1 commit into
mainfrom
claude/review-claude-board-files-nhqgx1
Jul 17, 2026
Merged

D-MBX-A6 output overhaul: StrategyOutcome carrier retires the dead-store _reliability#711
AdaWorldAPI merged 1 commit into
mainfrom
claude/review-claude-board-files-nhqgx1

Conversation

@AdaWorldAPI

Copy link
Copy Markdown
Owner

What

The planner-internal, unblocked slice of D-MBX-A6-P3: give StyleStrategy an honest carrier for the style-conditioned reliability it computes, instead of dead-storing it (let _reliability = …, the exact theatre the council flagged).

Why it was a dead store

StyleStrategy::plan() computes a style-conditioned reliability but discarded it, because the plan() return type PlanInput { plan, context } had nowhere to carry a cognitive outcome — and faking a KanbanMove/commit would be theatre.

The change

  • traits.rsStrategyOutcome { reliability: f32, intended_move: Option<KanbanMove> } + additive PlanInput.outcome: Option<StrategyOutcome> (default None, threaded unchanged by every pass-through strategy).
  • style_strategy.rsplan() now surfaces the reliability + an intended move: Planning → CognitiveWork (a legal Rubicon edge), mailbox 0 / cycle 0 (the zero-fallback bootstrap owner — write-on-behalf, not as ourselves; the live MailboxSoaOwner rebinds on adoption), libet -550_000 (Σ-commit anchor), exec Elixir (the backend reliability_of actually ran). The plan itself stays a pure pass-through — out.plan.is_none() is still asserted. This is a SURFACE, not an emit/commit/advance.
  • 6 in-crate PlanInput { … } literals gain outcome: None; the other ~15 plan() impls return Ok(input) untouched (additive field, no trait-signature change).

Gating — UNBLOCKED

No classid mint (pairs an existing f32 with the already-minted contract KanbanMove), and not the OQ-11.7 five-phase cutover. Deferred next nodes: thread the outcome OUT of compose_and_execute (a compose_and_collect() sibling), promote StrategyOutcome to contract::kanban on first cross-bridge read, and the owner-consume/advance edge (OQ-11.7).

Verification

  • cargo test -p lance-graph-planner216 lib + 4 probe tests green.
  • cargo clippy -p lance-graph-planner -- -D warnings → exit 0.
  • cargo fmt -p lance-graph-planner → clean.
  • plan_is_pure_passthrough_until_emit_edge_lands rewritten → plan_surfaces_outcome_without_mutating_the_plan (plan still None; outcome shape + legal-edge asserted).

Board hygiene (same commit)

EPIPHANIES E-STRATEGY-OUTCOME-CARRIER-1, STATUS_BOARD D-MBX-A6-P3b row, D-MBX-COMPLETION-MAP.md tee-append, AGENT_LOG.md entry.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Awg6TXocHcwTtc6eGsHcdD


Generated by Claude Code

…ore _reliability

StyleStrategy::plan() computed a style-conditioned reliability and discarded it
(`let _reliability = …`) because PlanInput had nowhere to carry a cognitive
outcome, and faking a KanbanMove/commit would be theatre. Add an honest carrier.

- traits.rs: `StrategyOutcome { reliability: f32, intended_move: Option<KanbanMove> }`
  + additive `PlanInput.outcome: Option<StrategyOutcome>` (default None, threaded
  unchanged by every pass-through strategy).
- style_strategy.rs: plan() now surfaces the reliability + an INTENDED move —
  Planning→CognitiveWork (a legal Rubicon edge), mailbox 0 / cycle 0 (the
  zero-fallback bootstrap owner, write-on-behalf, not as ourselves; the live
  owner rebinds on adoption), libet -550_000 (Σ-commit anchor), exec Elixir (the
  backend reliability_of actually ran). The plan itself stays a pure pass-through
  (out.plan.is_none() still asserted) — this is a SURFACE, not an emit/commit.
- 6 in-crate PlanInput{} literals gain `outcome: None`; the other ~15 plan()
  impls return Ok(input) untouched.

Gating: UNBLOCKED — no classid mint (pairs an existing f32 with the already-minted
contract KanbanMove), not the OQ-11.7 five-phase cutover. Deferred: thread the
outcome OUT of compose_and_execute, promote StrategyOutcome to contract::kanban on
first cross-bridge read, and the owner-consume/advance edge.

Tests: 216 lib + 4 probe green; clippy -D warnings exit 0; fmt clean.
Board: EPIPHANIES E-STRATEGY-OUTCOME-CARRIER-1, STATUS_BOARD D-MBX-A6-P3b,
D-MBX-COMPLETION-MAP, AGENT_LOG.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Awg6TXocHcwTtc6eGsHcdD
@cursor

cursor Bot commented Jul 17, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_df9827f9-4755-4244-9015-f8a60d4c34ee)

@AdaWorldAPI
AdaWorldAPI marked this pull request as ready for review July 17, 2026 13:57
@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@AdaWorldAPI, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 14 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 25c2f11b-c56b-4ad7-be84-eae92f9f60d3

📥 Commits

Reviewing files that changed from the base of the PR and between abbe15a and a69cef9.

📒 Files selected for processing (10)
  • .claude/board/AGENT_LOG.md
  • .claude/board/D-MBX-COMPLETION-MAP.md
  • .claude/board/EPIPHANIES.md
  • .claude/board/STATUS_BOARD.md
  • crates/lance-graph-planner/src/compose.rs
  • crates/lance-graph-planner/src/strategy/gql_parse.rs
  • crates/lance-graph-planner/src/strategy/gremlin_parse.rs
  • crates/lance-graph-planner/src/strategy/sparql_parse.rs
  • crates/lance-graph-planner/src/strategy/style_strategy.rs
  • crates/lance-graph-planner/src/traits.rs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@AdaWorldAPI
AdaWorldAPI merged commit b303ca1 into main Jul 17, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants