Skip to content

feat(contract): D-TRI-1 value-tenant half — autopoiesis triangle (3 SoA lanes)#717

Merged
AdaWorldAPI merged 3 commits into
mainfrom
claude/review-claude-board-files-nhqgx1
Jul 17, 2026
Merged

feat(contract): D-TRI-1 value-tenant half — autopoiesis triangle (3 SoA lanes)#717
AdaWorldAPI merged 3 commits into
mainfrom
claude/review-claude-board-files-nhqgx1

Conversation

@AdaWorldAPI

Copy link
Copy Markdown
Owner

What

The value-tenant half of the D-TRI-1 batched mint (triangle-tenants-gestalt-separation-v1.md §1). Three append-only ValueTenants carry the autopoiesis triangle as SoA lanes on the 512-byte NodeRow:

Tenant Disc Bytes row_offset Semantics
FrozenStyle 10 U8 × 12 152 checkpoint policy — the atom dispatch runs off
LearnedStyle 11 U8 × 12 164 NARS-revision-updated policy (L4 learning seam writes)
ExploreStyle 12 U8 × 12 176 exploration variant (P64 perturbation, deterministic jitter)

Appended after Kanban (which ends at 152) per the 2026-07-17 operator ruling — "triangle right after the kanban board". Triangle ends at 188; BoardAggregates (W2a) reserves row_offset 188 next.

Why this shape

  • Additive / reserve-don't-reclaim / layout-preserving. Occupies previously-unallocated tail bytes [152,188). Full carve 120→156 B, NODE_ROW_STRIDE (512) and VALUE_SLAB_LEN (480) unchanged → zero ENVELOPE_LAYOUT_VERSION bump.
  • In ValueSchema::Full only — deliberately NOT Cognitive. Cognitive resolves for entity classes (OSINT/PROJECT/ERP/Commerce) that should not inherit a thinking-style triangle. Full must carry every tenant (its compile assert). The thinking-row schema decision is deferred to P4 (ancestry pipeline); the lanes physically exist at fixed offsets in every slab, so accessors work regardless of schema.
  • One content-blind register, two readings (plan §4): slot f = StyleFamily ordinal 0..11 or compiled-template step 0..11, ClassView-selected. Atom 0 = null default (zero-fallback: an un-populated lane reads all-null, never a wrong policy).

Accessors

NodeRow::{style_lane(tenant) -> [u8;12], set_style_lane(tenant, [u8;12]), triangle_for(f) -> (u8,u8,u8)}. triangle_for(f) = (frozen[f], learned[f], explore[f]) — the one-glance per-family read the dispatch/perturbation/learning ancestry pipeline (P4) resolves against; set_style_lane is the owner-&mut write that resolves the W4b orphan-write flag.

Tests

  • NEW thinking_style_triangle_tenant_carve_field_isolation_matrix — the I-LEGACY field-isolation matrix: flips each lane, asserts only its 12 bytes change, key/edges/other tenants untouched; accessor round-trip; atom-0 zero-fallback; Full-carries / Cognitive-Compressed-do-not.
  • Updated Full.tenant_bytes() 120→156 (byte-budget, default-class, contiguity tests).
  • 906 contract lib tests green (default + guid-v3-tail); clippy -D warnings + fmt clean. N_TENANTS derives from VALUE_TENANTS.len() (tenant counters auto-size); no downstream tenant-count assumption.

Scope / follow-ons

This is only the value-tenant (layout) half. The classid half — chess domain 0x06 concepts, the Tasks-SoA task-row classid (cognitive-task concepts), and BoardAggregates @ row_offset 188 — remains queued as one batched OGAR-originated mint (never solo edits), cross-repo. P4 (ancestry-pipeline consolidation) wires the pipeline gems into these lanes.

Gated by the v3-envelope-auditor (layout gate).

🤖 Generated with Claude Code

https://claude.ai/code/session_01Awg6TXocHcwTtc6eGsHcdD


Generated by Claude Code

…oA lanes)

The value-tenant half of the D-TRI-1 batched mint
(triangle-tenants-gestalt-separation-v1.md §1). Three append-only
ValueTenants — FrozenStyle=10, LearnedStyle=11, ExploreStyle=12 — each
U8×12 palette256-atom lane, contiguous at row_offset 152/164/176
(value-slab [120,156)), appended after Kanban per the 2026-07-17 operator
ruling ("triangle right after the kanban board").

- Additive / reserve-don't-reclaim / layout-preserving: Full carve
  120→156 B, NODE_ROW_STRIDE 512 untouched, no ENVELOPE_LAYOUT_VERSION
  bump. In ValueSchema::Full ONLY (not Cognitive — entity classes
  OSINT/PROJECT/ERP keep their carve; the thinking-row schema decision
  is P4's).
- Slot f = StyleFamily ordinal 0..11 OR compiled-template step 0..11 (one
  content-blind register, ClassView-selected reading, plan §4). Atom 0 =
  null default (zero-fallback: an un-populated lane reads all-null).
- Accessors NodeRow::{style_lane, set_style_lane, triangle_for}.
  triangle_for(f) -> (frozen[f], learned[f], explore[f]) is the one-glance
  per-family read the dispatch/perturbation/learning ancestry pipeline (P4)
  resolves against; set_style_lane is the owner-&mut write resolving the
  W4b orphan-write flag.
- I-LEGACY field-isolation matrix test certifies per-lane byte isolation,
  key/edges/other-tenant untouched.

906 contract lib tests green (default + guid-v3-tail); clippy -D warnings
+ fmt clean. Board: STATUS_BOARD D-TRI-1, LATEST_STATE prepend.

The classid half (chess 0x06, Tasks-SoA task classid, BoardAggregates
@188) remains queued — one batched OGAR-originated mint, cross-repo.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Awg6TXocHcwTtc6eGsHcdD
@cursor

cursor Bot commented Jul 17, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_519d6732-5ffd-4aff-a5c7-462ceb8bdd80)

…ations

The v3-envelope-auditor's LAYOUT-CLEAN verdict on #717 (triangle value
tenants) flagged two non-blocking forward obligations that P4 must honor
when it wires the reader that decodes the lanes:
(1) the palette256 codebook must reserve index 0 as the null/no-op atom
    (else the zero-fallback silently reads a live policy);
(2) the P4 thinking-row ValueSchema must include the 3 triangle tenants
    (or thinking rows resolve to Full), else populated triangle bytes drop
    on a field_mask-driven persist.

Both recorded so P4 (D-TRI-2/3) inherits them.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Awg6TXocHcwTtc6eGsHcdD
@AdaWorldAPI
AdaWorldAPI marked this pull request as ready for review July 17, 2026 16:08
@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@AdaWorldAPI, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 26 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 2389afda-f941-4c55-872e-666238139679

📥 Commits

Reviewing files that changed from the base of the PR and between e9e00be and c875b94.

📒 Files selected for processing (4)
  • .claude/board/LATEST_STATE.md
  • .claude/board/STATUS_BOARD.md
  • .claude/board/TECH_DEBT.md
  • crates/lance-graph-contract/src/canonical_node.rs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f2390c9463

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread crates/lance-graph-contract/src/canonical_node.rs Outdated
…ts (Codex P2 #717)

triangle_for(family_ordinal >= 12) had only a debug_assert, so in release
the index ran past each 12-byte lane and aliased the next tenant's bytes
(slot 12 → LearnedStyle[0]/ExploreStyle[0]/reserved) — a wrong policy, not
the null the zero-fallback contract promises. Now returns the null triangle
(0,0,0) for out-of-range slots. style_lane/set_style_lane likewise made
release-safe (null read / no-op write) for a non-12-byte tenant instead of
a debug-only guard. Regression assertions added to the field-isolation test.

906 contract lib tests green; clippy -D warnings + fmt clean.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Awg6TXocHcwTtc6eGsHcdD
@AdaWorldAPI
AdaWorldAPI merged commit 74d16f9 into main Jul 17, 2026
6 checks passed
AdaWorldAPI pushed a commit that referenced this pull request Jul 17, 2026
LATEST_STATE entry IN PR → MERGED (#717, main 74d16f9); PR_ARC_INVENTORY
prepend for #717 (Added/Locked/Deferred/Docs/Confidence). The autopoiesis
triangle (3 SoA lanes) is on main; the classid half (chess 0x06 + Tasks-SoA
+ BoardAggregates@188) is the deferred next arc.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Awg6TXocHcwTtc6eGsHcdD
AdaWorldAPI added a commit that referenced this pull request Jul 17, 2026
…GED (#718)

LATEST_STATE entry IN PR → MERGED (#717, main 74d16f9); PR_ARC_INVENTORY
prepend for #717 (Added/Locked/Deferred/Docs/Confidence). The autopoiesis
triangle (3 SoA lanes) is on main; the classid half (chess 0x06 + Tasks-SoA
+ BoardAggregates@188) is the deferred next arc.


Claude-Session: https://claude.ai/code/session_01Awg6TXocHcwTtc6eGsHcdD

Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants