Skip to content

fix: preserve unbounded heartbeat compatibility - #1472

Merged
khaliqgant merged 1 commit into
mainfrom
fix/fleet-heartbeat-regression
Aug 10, 2026
Merged

fix: preserve unbounded heartbeat compatibility#1472
khaliqgant merged 1 commit into
mainfrom
fix/fleet-heartbeat-regression

Conversation

@khaliqgant

@khaliqgant khaliqgant commented Aug 10, 2026

Copy link
Copy Markdown
Member

Summary

  • keep nullable node.heartbeat.load decoding in place for the coordinated Relaycast rollout
  • temporarily emit legacy numeric load: 0 when max_agents == 0, so deployed Relaycast engines accept the whole heartbeat
  • add a producer serialization regression test covering load and active_agents
  • correct the changelog: remove the unshipped claim from 11.4.2 and describe the compatibility fix under Unreleased

Root cause

Relay #1445 began omitting load for unbounded providers. Fleet E2E pins Relaycast v6.0.1, which rejects heartbeats without a numeric load. Spawn and brief delivery still complete, but the entire heartbeat is discarded, so active_agents and load never update. This is the same wire-contract boundary addressed by Relaycast PR #307; it is a product compatibility defect, not a stale harness assertion.

The decisive comparison used the same local Node 22.14.0, Relaycast commit 58a9342, and release broker build:

Validation

  • patched Fleet E2E against pinned Relaycast v6.0.1: 3 consecutive passes / 0 failures, exit codes 0, 0, 0, 14/14 each
  • full broker suite: exit 0; 868 unit tests passed, 4 ignored; all broker integration tests passed
  • focused heartbeat tests: exit 0; 5 passed
  • cargo fmt --all -- --check: exit 0
  • git diff --check: exit 0

Release sequencing

Relaycast PR #307 must merge and deploy before Relay can safely switch unbounded heartbeat load back to omitted/null. Until then, numeric emission preserves active-agent and liveness updates across currently deployed engines without weakening Fleet E2E.

Review in cubic

@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 2d358aaa-106f-4f2f-a04e-0a15e9dba548

📥 Commits

Reviewing files that changed from the base of the PR and between 0b43dbe and a1c2c5c.

📒 Files selected for processing (3)
  • CHANGELOG.md
  • crates/broker/src/fleet_wire.rs
  • crates/broker/src/node_control.rs

📝 Walkthrough

Walkthrough

Unbounded-capacity fleet heartbeats now report load: 0.0 while preserving active_agents. Documentation and changelog entries describe compatibility with older engines and the temporary numeric-load requirement.

Changes

Fleet heartbeat compatibility

Layer / File(s) Summary
Heartbeat load compatibility contract
crates/broker/src/fleet_wire.rs, CHANGELOG.md
The documentation and changelog describe numeric load reporting during the rollout.
Numeric load generation and validation
crates/broker/src/node_control.rs
Unbounded heartbeats emit 0.0, and tests verify the serialized load and active agent count.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: willwashburn

Poem

A rabbit checks the heartbeat flow,
Zero load makes old engines glow.
Active agents still march in line,
The wire stays steady, clear, and fine.
Compatibility hops ahead! 🐇

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the primary heartbeat compatibility fix.
Description check ✅ Passed The description explains the change, root cause, release sequencing, and validation results; it omits the template headings for Test Plan and Screenshots.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/fleet-heartbeat-regression

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kjgbot
kjgbot marked this pull request as ready for review August 10, 2026 09:08
@kjgbot
kjgbot requested a review from willwashburn as a code owner August 10, 2026 09:08

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

Open in Devin Review

@khaliqgant
khaliqgant merged commit 4117a9e into main Aug 10, 2026
40 checks passed
@khaliqgant
khaliqgant deleted the fix/fleet-heartbeat-regression branch August 10, 2026 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant