Skip to content

fix(cli): preserve Relayfile timeout fallback for undefined options - #1489

Merged
khaliqgant merged 1 commit into
mainfrom
fix/relayfile-undefined-integration-timeout
Aug 12, 2026
Merged

fix(cli): preserve Relayfile timeout fallback for undefined options#1489
khaliqgant merged 1 commit into
mainfrom
fix/relayfile-undefined-integration-timeout

Conversation

@khaliqgant

@khaliqgant khaliqgant commented Aug 12, 2026

Copy link
Copy Markdown
Member

Summary

  • normalize an explicitly forwarded undefined requestTimeoutMs to the 30-second Relayfile integration default
  • preserve defined caller timeout overrides
  • add regression assertions for both cases

Follow-up to #1487 and the late Cubic finding in discussion_r3764394639.

Verification

  • npx vitest run packages/cli/src/cli/commands/integration-relayfile-contract.test.ts (12 passed, 4 skipped)
  • npm run typecheck
  • npx prettier --check CHANGELOG.md packages/cli/src/cli/commands/integration.ts packages/cli/src/cli/commands/integration-relayfile-contract.test.ts
  • git diff --check

Review in cubic

@cursor

cursor Bot commented Aug 12, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: bcd43117-73da-4d6f-9111-95de739af15d

📥 Commits

Reviewing files that changed from the base of the PR and between 06f147a and 4489dfc.

📒 Files selected for processing (3)
  • CHANGELOG.md
  • packages/cli/src/cli/commands/integration-relayfile-contract.test.ts
  • packages/cli/src/cli/commands/integration.ts
 ______________________________________________
< Looking for trouble in all the right places. >
 ----------------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/relayfile-undefined-integration-timeout

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Re-trigger cubic

@khaliqgant
khaliqgant merged commit 6ea4240 into main Aug 12, 2026
41 checks passed
@khaliqgant
khaliqgant deleted the fix/relayfile-undefined-integration-timeout branch August 12, 2026 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant