fix(auth): Hole 1 — bind agent sponsor to SSO-authenticated human, refuse workspace-key-set sponsors + hash-chained audit - #80
Draft
kjgbot wants to merge 1 commit into
Draft
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause and impact
The sponsor API already verified an OIDC ID token and issued a short-lived RS256 sponsor proof, but legacy identity creation could still accept a sponsor selected by a workspace-key holder. Attestation issuance then trusted that legacy identity sponsorship. That allowed shared workspace-key holders to become indistinguishable in the evidence chain.
Identity creation now fails closed for workspace-token callers unless the organization requires OIDC sponsor binding and the caller supplies a valid RelayAuth sponsor proof. Attestation grant issuance independently requires the stored identity sponsor binding to be OIDC.
Audit Gap 3
The security evidence store already exists as attestation_ledger. It is append-only, has no update or retention deletion path, uses a per-organization SHA-256 prev_hash/entry_hash chain, and stores RS256-signed JWS entries. The separately retained audit_logs table remains the operational query feed and is explicitly not treated as the write-once evidence ledger. No redundant migration was added.
Validation
Known repository baseline
The monorepo build reaches an existing TypeScript package-boundary error because @relayauth/migrate does not emit a declaration file consumed by the server package. The server tests, including the new security coverage, pass.