Skip to content

fix(core): validate persona builder options - #30

Merged
barryollama merged 2 commits into
mainfrom
codex/relayflows-persona-builder-validation
Aug 11, 2026
Merged

fix(core): validate persona builder options#30
barryollama merged 2 commits into
mainfrom
codex/relayflows-persona-builder-validation

Conversation

@barryollama

Copy link
Copy Markdown
Contributor

Follow-up to #29 addressing the valid CodeRabbit union-construction finding before release.

  • construct CLI and persona agent definitions in separate branches
  • reject both/neither selectors for untyped runtime callers
  • reject persona-incompatible role/model/preset/interactive:false fields
  • keep model constraints CLI-only
  • add runtime regression coverage

Verification: core build, core typecheck, and 83 affected builder/persona/runner tests pass.

@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@barryollama, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 30 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 42a49672-bd0a-4d10-a27c-ffefbc0cb3bf

📥 Commits

Reviewing files that changed from the base of the PR and between 1ac4ee4 and 69a8489.

📒 Files selected for processing (2)
  • packages/core/src/__tests__/builder-agent-round-trip.test.ts
  • packages/core/src/builder.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 2 files

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread packages/core/src/builder.ts Outdated
@barryollama

Copy link
Copy Markdown
Contributor Author

Addressed Cubic's duplication finding in 69a8489: the model-free shared constraints are now built once, and only the CLI branch adds model. Core build, typecheck, and all six builder tests pass.

@barryollama
barryollama merged commit f691a4a into main Aug 11, 2026
2 checks passed
@barryollama
barryollama deleted the codex/relayflows-persona-builder-validation branch August 11, 2026 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants