Ready to deploy - #40
Merged
Merged
Conversation
Notifications are the app's first custom context — the first value needing tree-wide reach. The provider owns a ten-entry history with read tracking; useNotify serves the mutation call sites and useNotifications serves the header bell. Provider and hooks live in separate files so react-refresh keeps hot reload. Transient toasts were prototyped and deliberately dropped: two presentations of one event prototyped and deliberately dropped: two presentations of one event stream duplicated a function, and failures already surface inline in the dialog that caused them.
…audit fixes the bell, delete-dialog inline alert, and doc updates
Feature/mutations
The header search debounces into ?q= and five filter chips (status, estimate, tags, due date, owner) write their own params, so filtered views are shareable, survive reloads, and never remount the page — search params sit outside the pathname the error boundary keys on. filterInputFromParams is the one validated boundary from URL strings to the typed FilterTaskInput; unknown values are dropped. Filters combine freely and an empty-results component with a clear-filters path renders when nothing matches. MenuPanel graduates from TaskForm to a shared component so the filter chips reuse the app's menu anatomy. Probing the component so the filter chips reuse the app's menu anatomy. Probing the live API first shaped the implementation and the README notes: name matching is a case-sensitive substring, dueDate matches by exact timestamp (satisfied by this app's noon-UTC convention), and ownerId is accepted but ignored server-side — sent as required, documented as observed.
The server ignores ownerId, so the owner chip changed nothing — a placebo control. The tasks query now selects creator id and TasksView filters locally when an owner is set, while the param is still sent as the requirement demands. The header search gains a last-pushed ref so external URL changes (clear filters, back/forward) sync into the input instead of being re-pushed by the stale debounce. parseDueParam becomes the single validated accessor for the due param, checking shape and calendar round-trip so junk or rollover dates mean no filter rather than an Invalid Date chip. Removes the stale unchecked search-and-filter checklist line.
Search and filter tasks through url search params
Show the user profile settings
Feature/bonus points
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.