Fix books not dimming the world behind them - #229
Open
digi2303 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening a book on 1.21 doesn't dim the world behind it the way it does on 1.20.
GuiBasicBookhas an emptyrenderMenuBackgroundoverride. It was added in c9fe2ea and hasn't shipped in a release, so it only affects this branch.Deleting it isn't quite enough though. On 1.21
Screen.rendercallsrenderBackgrounditself, which it didn't do on 1.20, so the background got drawn a second time over the finished book. And the old 1.20 gradient is still there asrenderTransparentBackground, nothing just calls it anymore.So this makes
renderBackgrounda no-op and draws the background once inrender(), before the book. Theflush()is needed becausefillGradientis batched whileBookBlitdraws immediately, same asdrawEntityOnScreenalready does.renderBlurredBackgroundis unreachable now. The blur stays off anyway, happy to remove it if you'd rather.