[Algorithm] Remove unused parser and TableView utilities#15558
Open
sawenzel wants to merge 1 commit into
Open
Conversation
sawenzel
requested review from
davidrohr,
matthiasrichter,
shahor02 and
wiechula
as code owners
The header-only utilities Parser.h (ForwardParser/ReverseParser), TableView.h, O2FormatParser.h and PageParser.h have no users: the only o2::algorithm:: symbol referenced anywhere outside the module (across AliceO2 and O2Physics) is flatten, from FlattenRestore.h. These four headers are exercised solely by their own unit tests, and the #include "Algorithm/Parser.h" lines in GPU/TPC sources reference none of their symbols. Remove the headers, their tests, the corresponding o2_add_test entries, and the stale includes. RangeTokenizer.h, FlattenRestore.h, HeaderStack.h and mpl_tools.h (the parts actually in use) are untouched. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
sawenzel
force-pushed
the
cleanup/remove-unused-algorithm-parser
branch
from
6c7d348 to
616c54d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A small cleanup. The header-only utilities
Parser.h(ForwardParser/ReverseParser),TableView.h,O2FormatParser.handPageParser.hin theAlgorithmmodule have no callers: the onlyo2::algorithm::symbol used anywhere outside the module — in AliceO2 and O2Physics — isflatten(fromFlattenRestore.h). These four headers are referenced only by their own unit tests, and the#include "Algorithm/Parser.h"lines in GPU/TPC sources reference none of their symbols (stale includes).This removes the unused headers, their tests, the corresponding
o2_add_testentries, and the 5 stale includes. The actively-used parts of the module (RangeTokenizer.h,FlattenRestore.h,HeaderStack.h,mpl_tools.h) are untouched. Pure dead-code removal — no behavioural change.🤖 Generated with Claude Code