Skip to content

[PWGLF] Add QA histograms - #17440

Open
romainschotter wants to merge 4 commits into
masterfrom
romainschotter-patch-2
Open

[PWGLF] Add QA histograms#17440
romainschotter wants to merge 4 commits into
masterfrom
romainschotter-patch-2

Conversation

@romainschotter

Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions github-actions Bot added the pwglf label Aug 12, 2026
@github-actions github-actions Bot changed the title Add QA histograms [PWGLF] Add QA histograms Aug 12, 2026
@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 12 errors, ⚠️ 14 warnings, 🔕 0 disabled

@romainschotter
romainschotter marked this pull request as ready for review August 12, 2026 20:51
@romainschotter
romainschotter enabled auto-merge (squash) August 12, 2026 20:51
alibuild
alibuild previously approved these changes Aug 12, 2026

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @romainschotter.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 21279dd at 2026-08-12 23:05:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 30 errors and 55 warnings.'
Found 30 errors and 55 warnings.
++ [[ 30 -gt 0 ]]
++ cat /sw/BUILD/c1d44f7c48997251af9933ad6c4235c9a199ef0e/O2Physics-code-check/errors.txt
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:31:1: error: included header mcCentrality.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:37:1: error: included header TriggerAliases.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:53:1: error: included header DataTypes.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:62:1: error: included header TMath.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:64:1: error: included header TProfile.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:66:1: error: included header types.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:68:1: error: included header algorithm is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:84:27: error: no header providing "ROOT::Math::SVector" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:85:31: error: no header providing "ROOT::Math::SMatrix" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:85:65: error: no header providing "ROOT::Math::MatRepSym" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:89:9: error: function-like macro 'BITSET' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:90:9: error: function-like macro 'BITCHECK' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:101:8: error: constructor does not initialize these fields: ccdb, mRunNumber, magField, lut, maskTopological, maskTrackProperties, maskK0ShortSpecific, maskLambdaSpecific, maskAntiLambdaSpecific, maskD0Specific, maskAntiD0Specific, maskSelectionK0Short, maskSelectionLambda, maskSelectionAntiLambda, maskSelectionD0, maskSelectionAntiD0, secondaryMaskSelectionLambda, secondaryMaskSelectionAntiLambda [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:157:20: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:183:67: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:301:13: error: no header providing "o2::base::MatLayerCylSet" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:371:52: error: no header providing "o2::aod::EvSels" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:1065:45: error: the parameter 'collision' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:1087:17: error: no header providing "o2::base::Propagator" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:1961:5: error: redundant return statement at the end of a function with a void return type [readability-redundant-control-flow,-warnings-as-errors]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:2021:5: error: redundant return statement at the end of a function with a void return type [readability-redundant-control-flow,-warnings-as-errors]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:2060:34: error: no header providing "o2::track::TrackParCovFwd" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:2065:12: error: redundant explicit casting to the same type 'float' as the sub-expression, remove this casting [readability-redundant-casting,-warnings-as-errors]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:2170:7: error: no header providing "TVector3" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:2329:92: error: no header providing "TObject" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:2557:148: error: no header providing "o2::aod::CentNGlobals" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:2557:167: error: no header providing "o2::aod::CentFV0As" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:2557:183: error: no header providing "o2::aod::CentFT0Ms" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:2557:199: error: no header providing "o2::aod::CentFT0Cs" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:2557:215: error: no header providing "o2::aod::CentFT0CVariant1s" is directly included [misc-include-cleaner,-warnings-as-errors]
++ [[ 55 -gt 0 ]]
++ cat /sw/BUILD/c1d44f7c48997251af9933ad6c4235c9a199ef0e/O2Physics-code-check/warnings.txt
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:696:24: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:698:23: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:700:27: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:702:19: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:704:23: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:1267:32: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:1272:32: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:1277:32: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:1282:32: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:1287:32: warning: statement should be inside braces [readability-braces-around-statements]
[0 more errors; see full log]

Full log here.

alibuild
alibuild previously approved these changes Aug 12, 2026

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @romainschotter.

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @romainschotter.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 35936a2 at 2026-08-13 04:41:

## sw/BUILD/lhapdf-latest/log
collect2: error: ld returned 1 exit status


## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 30 errors and 55 warnings.'
Found 30 errors and 55 warnings.
++ [[ 30 -gt 0 ]]
++ cat /sw/BUILD/64c6b1377cabb862b3db62982fc2a7239d8064cb/O2Physics-code-check/errors.txt
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:31:1: error: included header mcCentrality.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:37:1: error: included header TriggerAliases.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:53:1: error: included header DataTypes.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:62:1: error: included header TMath.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:64:1: error: included header TProfile.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:66:1: error: included header types.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:68:1: error: included header algorithm is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:84:27: error: no header providing "ROOT::Math::SVector" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:85:31: error: no header providing "ROOT::Math::SMatrix" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:85:65: error: no header providing "ROOT::Math::MatRepSym" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:89:9: error: function-like macro 'BITSET' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:90:9: error: function-like macro 'BITCHECK' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:101:8: error: constructor does not initialize these fields: ccdb, mRunNumber, magField, lut, maskTopological, maskTrackProperties, maskK0ShortSpecific, maskLambdaSpecific, maskAntiLambdaSpecific, maskD0Specific, maskAntiD0Specific, maskSelectionK0Short, maskSelectionLambda, maskSelectionAntiLambda, maskSelectionD0, maskSelectionAntiD0, secondaryMaskSelectionLambda, secondaryMaskSelectionAntiLambda [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:157:20: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:183:67: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:301:13: error: no header providing "o2::base::MatLayerCylSet" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:371:52: error: no header providing "o2::aod::EvSels" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:1065:45: error: the parameter 'collision' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:1087:17: error: no header providing "o2::base::Propagator" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:1961:5: error: redundant return statement at the end of a function with a void return type [readability-redundant-control-flow,-warnings-as-errors]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:2021:5: error: redundant return statement at the end of a function with a void return type [readability-redundant-control-flow,-warnings-as-errors]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:2060:34: error: no header providing "o2::track::TrackParCovFwd" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:2065:12: error: redundant explicit casting to the same type 'float' as the sub-expression, remove this casting [readability-redundant-casting,-warnings-as-errors]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:2170:7: error: no header providing "TVector3" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:2329:92: error: no header providing "TObject" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:2557:148: error: no header providing "o2::aod::CentNGlobals" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:2557:167: error: no header providing "o2::aod::CentFV0As" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:2557:183: error: no header providing "o2::aod::CentFT0Ms" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:2557:199: error: no header providing "o2::aod::CentFT0Cs" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:2557:215: error: no header providing "o2::aod::CentFT0CVariant1s" is directly included [misc-include-cleaner,-warnings-as-errors]
++ [[ 55 -gt 0 ]]
++ cat /sw/BUILD/64c6b1377cabb862b3db62982fc2a7239d8064cb/O2Physics-code-check/warnings.txt
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:696:24: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:698:23: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:700:27: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:702:19: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:704:23: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:1267:32: warning: statement should be inside braces [readability-braces-around-statements]
[0 more errors; see full log]

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants