test: lock in sequential focus with an auto-focus-on-load field (PT-21)#172
Merged
Conversation
A report reopened PT-21, claiming sequential tap+type across fields breaks specifically when one field requests focus during initState (e.g. a "remember last email" convenience feature) - text supposedly keeps landing in the auto-focused field regardless of which field is tapped afterward. Re-investigated with the exact discriminator described: a widget test with one field auto-focusing via a post-frame requestFocus(), plus real-device verification against the actual login screen with the same pattern temporarily added (both tap orders, iOS simulator). Both pass cleanly - focus correctly shifts to whichever field is tapped, each field retains only its own typed value. Adding a regression test to lock this in, matching the PT-11 precedent for reported-but-non-reproducing behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A report reopened PT-21, claiming sequential tap+type across fields breaks specifically when one field requests focus during
initState(e.g. a "remember last email" convenience feature) -- text supposedly keeps landing in the auto-focused field regardless of which field is tapped afterward.Re-investigated with the exact discriminator described: a widget test with one field auto-focusing via a post-frame
requestFocus(), plus real-device verification against the actual login screen with the same pattern temporarily added (both tap orders, iOS simulator, using real screenshots for visual confirmation).Both pass cleanly -- focus correctly shifts to whichever field is tapped, each field retains only its own typed value. Adding a regression test to lock this in, matching the PT-11 precedent for reported-but-non-reproducing behavior.
Test plan
go build ./...,go vet ./...,go test ./...all passstaticcheck ./...cleandart analyze lib/clean,flutter testall pass (33 tests, including the new one)