Antalya 26.5: Support Nullable(Tuple) for Arrow, ArrowStream, ORC, legacy Parquet formats#1976
Open
zvonand wants to merge 2 commits into
Open
Antalya 26.5: Support Nullable(Tuple) for Arrow, ArrowStream, ORC, legacy Parquet formats#1976zvonand wants to merge 2 commits into
zvonand wants to merge 2 commits into
Conversation
…next commit) --- Original cherry-pick message follows: Merge pull request #1802 from Altinity/feature/antalya-26.3/ClickHouse-ClickHouse-pr-101272 Antalya 26.3: Support Nullable(Tuple) for Arrow, ArrowStream, ORC, legacy Parquet formats # Conflicts: # src/Processors/Formats/Impl/CHColumnToArrowColumn.cpp # src/Processors/Formats/Impl/MsgPackRowInputFormat.cpp # tests/queries/0_stateless/04065_tuple_inside_nullable_parquet_roundtrip.reference # tests/queries/0_stateless/04065_tuple_inside_nullable_parquet_roundtrip.sql
CHColumnToArrowColumn.cpp: kept antalya-26.5's architecture (children array + nullBytemapToArrowBitmap + arrow::StructArray::Make) which already incorporates the key changes from the source PR: passing nullptr instead of null_bytemap to nested fillArrowArray calls, and handling struct-level nulls via the null bitmap. The source PR's builder.AppendNull/Append loop is the antalya-26.3 equivalent of antalya-26.5's StructArray::Make with null_bitmap. MsgPackRowInputFormat.cpp: moved the Nullable-unwrapping block to before the tuple_type/size-check lines, matching the source PR's ordering. Test files: kept the antalya-26.5 adaptation (V3-reader-only queries, no input_format_parquet_use_native_reader_v3 variants) because the setting is MAKE_OBSOLETE in antalya-26.5 — V3 reader is always used and the = 0 Arrow reader path cannot be enabled via the setting.
zvonand
added
releasy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Support Nullable(Tuple) for Arrow, ArrowStream, ORC, legacy Parquet formats (ClickHouse#101272 by @nihalzp) (#1802 by @zvonand).
CI/CD Options
Exclude tests:
Regression jobs to run:
Cherry-picked from #1802.