fix: avoid logging env dashboard password

[LIghtJUNction]

Motivation

• Prevent accidental leakage of operator-provided dashboard secrets when the app prints the startup WebUI banner.
• The previous behavior stored ASTRBOT_DASHBOARD_INITIAL_PASSWORD in the transient _generated_dashboard_password attribute which was later included verbatim in logger output.
• Keep existing functionality that hashes and enforces the initial password while removing the one-shot plaintext exposure to logs.

Description

• Change AstrBotConfig._reset_generated_dashboard_password to avoid setting self._generated_dashboard_password when ASTRBOT_DASHBOARD_INITIAL_PASSWORD is present in the environment by writing generated_password if DASHBOARD_INITIAL_PASSWORD_ENV not in os.environ else None into the attribute.
• Preserve hashing of the provided password into conf['dashboard']['pbkdf2_password'] and legacy MD5 field so authentication behavior is unchanged.
• Update the unit test test_empty_dashboard_password_uses_initial_password_env to assert that env-provided passwords are hashed into config but are not exposed via config._generated_dashboard_password.

Testing

• Ran code style checks with uv run --no-sync ruff format astrbot/core/config/astrbot_config.py tests/unit/test_config.py and uv run --no-sync ruff check astrbot/core/config/astrbot_config.py tests/unit/test_config.py, which passed.
• Attempted to run uv run --no-sync pytest tests/unit/test_config.py -q, but test execution was blocked due to missing test runtime dependency pytest_asyncio in the environment.
• Static/diff validation verifies astrbot/core/config/astrbot_config.py and tests/unit/test_config.py were updated to implement and assert the new non-logging behavior.

---

Codex Task

Summary by Sourcery

Ensure environment-provided dashboard passwords are no longer stored in a runtime attribute that is later logged, while keeping authentication behavior unchanged.

Bug Fixes:

• Stop exposing the ASTRBOT_DASHBOARD_INITIAL_PASSWORD value via the generated dashboard password attribute that can end up in logs.

Tests:

• Update dashboard password configuration tests to confirm env-provided passwords are hashed into config but not exposed via the generated password attribute.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[gemini-code-assist]

Code Review

This pull request ensures that when the dashboard initial password is provided via an environment variable, the generated dashboard password attribute is set to None instead of exposing the password. The corresponding unit test has been updated to verify this behavior, ensuring that env-provided passwords are secure and not exposed. I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[sourcery-ai]

Hey - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[cloudflare-workers-and-pages]

Deploying with    Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status	Name	Latest Commit	Preview URL	Updated (UTC)
✅ Deployment successful! View logs	astrbot-docs	d5826a3	Commit Preview URL Branch Preview URL	Jul 04 2026, 09:02 AM

[LIghtJUNction]

This was also intentionally designed.

[LIghtJUNction]

It's best not to put passwords in the logs, but I don't think it matters that much.