Skip to content

Show manager request notifications for low-score users#984

Merged
raymondjacobson merged 1 commit into
mainfrom
codex/show-manager-request-notifications
Jun 30, 2026
Merged

Show manager request notifications for low-score users#984
raymondjacobson merged 1 commit into
mainfrom
codex/show-manager-request-notifications

Conversation

@raymondjacobson

Copy link
Copy Markdown
Member

Summary

  • allow private manager request notification types to bypass the aggregate-user score cutoff while still requiring the referenced user to be current and active
  • add a regression test for request_manager notifications from low-score grantor accounts

Prod evidence

  • pending grant exists for @ray62926 -> @Rayjacobson at block 120202429
  • raw notification row exists for user id 1 with type request_manager
  • /v1/notifications/7eP5n?types=request_manager currently returns empty because @ray62926 has aggregate_user.score = -111

Tests

  • go test ./api -run TestV1Notifications
  • go test ./api

@raymondjacobson raymondjacobson merged commit eb82dae into main Jun 30, 2026
5 checks passed
@raymondjacobson raymondjacobson deleted the codex/show-manager-request-notifications branch June 30, 2026 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant