Fix cfgit read-path footguns#15
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
devfallback fromenv:DEV_MONGODB_URIto genericMONGODB_URI@N, but make bare numeric ref misses point users to@Ncfgitandcfgit-impactto0.1.3for the next PyPI releaseWhy
The read path was not broken. The confusing behavior came from two footguns: missing
DEV_MONGODB_URIcould silently point cfgit at a different database viaMONGODB_URI, and typing12instead of@12produced a technically correct but unhelpful ref error.Validation
python -m pytest tests/test_config.py tests/test_engine_safety.py tests/test_mongo_history.py tests/test_postgres_history.py -qpython -m pytest -qtwiceruff check ...git diff --check0.1.3twine checkon both wheels